On 06/04/2020 15:22, Alex Dettinger wrote:
Hey Amos,
Thanks for input, in such a situation:
+ qute templates would be included anyway independently of
include/exclude patterns
+ resources matching include patterns only would be included
+ except resources matching include and exclude patterns that would not
be included
So we may end up in a situation where a user trying to exclude a
qute resource would be confused.
This is an interesting perspective to keep in mind, that would certainly
fit a discussion at quarkus level.
If there is no show stopper, I will ping the quarkus community in
https://github.com/quarkusio/quarkus/issues/2746.
FYI, I asked about that on quarkus-dev about a week ago:
https://groups.google.com/forum/#!topic/quarkus-dev/SLuS7DiDMVA
-- P
Many thanks,
Alex
On Wed, Apr 1, 2020 at 8:32 AM Zheng Feng <[email protected]> wrote:
I just have some concerns about some extensions which have implemented the
scanning and registering the resources, just like quarkus-qute [1].
It could detect the templates files under src/main/resources/templates with
the suffix (.txt, .html, etc). Is there any side effect if we set the
excludes pattern
just like quarkus.resources.excludes=**/*.txt ?
Regards,
Amos
[1] https://quarkus.io/guides/qute
On Wed, Apr 1, 2020 at 1:37 AM Alex Dettinger <[email protected]>
wrote:
Hello fellow Cameleers,
In Camel Quarkus, we have recently introduced the possibility to embed
some resources in the native executable via simple configuration (1). We
basically specify include/exclude patterns (2) in application.properties,
and embed matching resources in the native executable at build time.
The same kind of need has already been filed at Quarkus level (3). So
it
could make sense to open a discussion to promote include/exclude patterns
to quarkus. Especially, would one see any issue about proposing the
promotion of PathFilter (4) from Camel Quarkus and AntPathMatcher (5)
from
Camel ?
(1)
https://github.com/apache/camel-quarkus/commit/b0600f9f7a637b1a17167f86f7208fcc98739012
(2)
https://github.com/apache/camel-quarkus/blob/abb274d1d3ecd0aa3458c2ee0628d756d78825d2/docs/modules/ROOT/pages/native-mode.adoc#embedding-resource-in-native-executable
(3) https://github.com/quarkusio/quarkus/issues/2746
(4)
https://github.com/apache/camel-quarkus/blob/master/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/util/PathFilter.java
(5)
https://github.com/apache/camel/blob/master/core/camel-util/src/main/java/org/apache/camel/util/AntPathMatcher.java
Cheers,
Alex
