Thanks for your explanations. I think I managed to fix this in favour of downstream projects. Please review:
https://github.com/apache/camel/pull/4853 <https://github.com/apache/camel/pull/4853> And that change in camel-dependencies pom is not by me but through the build itself. > On 9 Jan 2021, at 14:51, Andrea Cosentino <anco...@gmail.com> wrote: > > and that's why I'm saying to revert and leave the situation as-is. > > Il giorno sab 9 gen 2021 alle ore 14:50 Andrea Cosentino <anco...@gmail.com> > ha scritto: > >> when we divided the subprojects, we need to find a way to depend from the >> set of version of parent pom, without all the stuff declared on parent pom >> in terms of build and maven plugins. >> >> The only way to do this, is copying the property placeholders versions in >> a new pom, based on the Apache Parent POM and make all the downstream >> projects use this camel-dependencies pom as their own parent pom. >> >> That's why, impsort property placeholder needs to be there. If someone is >> using the placeholder from the camel-dependencies pom, they will see their >> build fail. >> >> Il giorno sab 9 gen 2021 alle ore 14:19 Babak Vahdat < >> babak.vah...@swissonline.ch> ha scritto: >> >>> My point was to avoid declaring two different maven properties for the >>> same purpose. In Camel POM we used to have >>> >>> <impsort-maven-plugin.version>1.4.1</impsort-maven-plugin.version> >>> >>> And in parent POM we used to have >>> >>> <impsort-maven-plugin-version>1.4.1</impsort-maven-plugin-version> >>> >>> Note that one property with dot and the other one with dash. >>> >>> Was that really on purpose? Can you think of any way to avoid this >>> duplicate declaration other than the one I provided which apparently breaks >>> the build for the downstream projects? >>> >>> >>>> On 9 Jan 2021, at 14:01, Andrea Cosentino <anco...@gmail.com> wrote: >>>> >>>> It must be reverted anyway. The downstream projects depend on >>>> camel-dependencies >>>> >>>> Il sab 9 gen 2021, 13:51 Babak Vahdat <babak.vah...@swissonline.ch> ha >>>> scritto: >>>> >>>>> Let me do that and I will report back. It will take a while. >>>>> >>>>>> On 9 Jan 2021, at 13:49, Andrea Cosentino <anco...@gmail.com> wrote: >>>>>> >>>>>> Without fastinstall >>>>>> >>>>>> Il sab 9 gen 2021, 13:49 Andrea Cosentino <anco...@gmail.com> ha >>>>> scritto: >>>>>> >>>>>>> You need a full build. >>>>>>> >>>>>>> Il sab 9 gen 2021, 13:47 Babak Vahdat <babak.vah...@swissonline.ch> >>> ha >>>>>>> scritto: >>>>>>> >>>>>>>> I just did >>>>>>>> >>>>>>>> $> mvn clean install -Psourcecheck,fastinstall >>>>>>>> >>>>>>>> On the camel root folder and it was successful. >>>>>>>> >>>>>>>>> On 9 Jan 2021, at 13:44, Andrea Cosentino <anco...@gmail.com> >>> wrote: >>>>>>>>> >>>>>>>>> If the impsort version is not defined the full build should fail. I >>>>>>>> don't >>>>>>>>> have the build, but I suppose it will fail. >>>>>>>>> >>>>>>>>> Il sab 9 gen 2021, 13:42 Babak Vahdat <babak.vah...@swissonline.ch >>>> >>>>> ha >>>>>>>>> scritto: >>>>>>>>> >>>>>>>>>> Hi >>>>>>>>>> >>>>>>>>>> Where do you see the broken build? I can’t spot it. >>>>>>>>>> >>>>>>>>>>> On 9 Jan 2021, at 13:31, Andrea Cosentino <anco...@gmail.com> >>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> The camel-dependencies are based on parent. And it is >>> autogenerated >>>>>>>> from >>>>>>>>>>> catalog. So please revert. The build is broken with this commit. >>>>>>>>>>> >>>>>>>>>>> Il sab 9 gen 2021, 12:42 <bvah...@apache.org> ha scritto: >>>>>>>>>>> >>>>>>>>>>>> This is an automated email from the ASF dual-hosted git >>> repository. >>>>>>>>>>>> >>>>>>>>>>>> bvahdat pushed a commit to branch master >>>>>>>>>>>> in repository https://gitbox.apache.org/repos/asf/camel.git >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> The following commit(s) were added to refs/heads/master by this >>>>> push: >>>>>>>>>>>> new cc34db7 let's declare the impsort-maven-plugin version >>> only >>>>>>>> in >>>>>>>>>>>> one place >>>>>>>>>>>> cc34db7 is described below >>>>>>>>>>>> >>>>>>>>>>>> commit cc34db7f3051e37f8aaed34d6964240976955053 >>>>>>>>>>>> Author: Babak Vahdat <bvah...@apache.org> >>>>>>>>>>>> AuthorDate: Sat Jan 9 12:41:50 2021 +0100 >>>>>>>>>>>> >>>>>>>>>>>> let's declare the impsort-maven-plugin version only in one place >>>>>>>>>>>> --- >>>>>>>>>>>> camel-dependencies/pom.xml | 2 +- >>>>>>>>>>>> parent/pom.xml | 1 - >>>>>>>>>>>> pom.xml | 2 +- >>>>>>>>>>>> 3 files changed, 2 insertions(+), 3 deletions(-) >>>>>>>>>>>> >>>>>>>>>>>> diff --git a/camel-dependencies/pom.xml >>>>> b/camel-dependencies/pom.xml >>>>>>>>>>>> index 5854a67..6f6d7c7 100644 >>>>>>>>>>>> --- a/camel-dependencies/pom.xml >>>>>>>>>>>> +++ b/camel-dependencies/pom.xml >>>>>>>>>>>> @@ -270,7 +270,7 @@ >>>>>>>>>>>> <ical4j-version>1.0.7</ical4j-version> >>>>>>>>>>>> <icu4j-version>65.1</icu4j-version> >>>>>>>>>>>> <ignite-version>2.9.1</ignite-version> >>>>>>>>>>>> - >>>>>>>> <impsort-maven-plugin-version>1.3.2</impsort-maven-plugin-version> >>>>>>>>>>>> + >>>>>>>> <impsort-maven-plugin-version>1.4.1</impsort-maven-plugin-version> >>>>>>>>>>>> <infinispan-version>11.0.8.Final</infinispan-version> >>>>>>>>>>>> <influx-guava-version>20.0</influx-guava-version> >>>>>>>>>>>> <influx-java-driver-version>2.20</influx-java-driver-version> >>>>>>>>>>>> diff --git a/parent/pom.xml b/parent/pom.xml >>>>>>>>>>>> index 056337b..99eb2cb 100644 >>>>>>>>>>>> --- a/parent/pom.xml >>>>>>>>>>>> +++ b/parent/pom.xml >>>>>>>>>>>> @@ -250,7 +250,6 @@ >>>>>>>>>>>> <ical4j-version>1.0.7</ical4j-version> >>>>>>>>>>>> <icu4j-version>65.1</icu4j-version> >>>>>>>>>>>> <ignite-version>2.9.1</ignite-version> >>>>>>>>>>>> - >>>>>>>>>> <impsort-maven-plugin-version>1.3.2</impsort-maven-plugin-version> >>>>>>>>>>>> <infinispan-version>11.0.8.Final</infinispan-version> >>>>>>>>>>>> >>> <influx-java-driver-version>2.20</influx-java-driver-version> >>>>>>>>>>>> <influx-guava-version>20.0</influx-guava-version> >>>>>>>>>>>> diff --git a/pom.xml b/pom.xml >>>>>>>>>>>> index dc7825d..9f14176 100644 >>>>>>>>>>>> --- a/pom.xml >>>>>>>>>>>> +++ b/pom.xml >>>>>>>>>>>> @@ -117,7 +117,7 @@ >>>>>>>>>>>> <!-- we need to override the version inherited from Apache >>>>> POM >>>>>>>>>>>> for modules that use this POM as parent --> >>>>>>>>>>>> >>>>>>>>>>>> >>>>> <surefire.version>${maven-surefire-plugin-version}</surefire.version> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>> >>> <formatter-maven-plugin.version>2.12.1</formatter-maven-plugin.version> >>>>>>>>>>>> - >>>>>>>>>> <impsort-maven-plugin.version>1.4.1</impsort-maven-plugin.version> >>>>>>>>>>>> + >>>>>>>>>> <impsort-maven-plugin-version>1.4.1</impsort-maven-plugin-version> >>>>>>>>>>>> <java-diff-utils-version>4.7</java-diff-utils-version> >>>>>>>>>>>> >>>>>>>> <maven-bundle-plugin-version>4.2.1</maven-bundle-plugin-version> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>> >>>>>>>> >>>>> >>>>> >>> >>>
