nicolaferraro commented on pull request #2:
URL: https://github.com/apache/camel-kamelets/pull/2#issuecomment-777409589


   > > > @nicolaferraro perhaps you can start a pull request with the changes 
needed to the website on the website repository. Not sure what's to gain by 
adding those changes here. Is the end goal to publish to a different domain?
   > > 
   > > 
   > > No, it's only for the Camel website, I did them here just to have a 
quick preview in dev + I want later to integrate Netlify on PR.. but the code 
is well separated so the plan was to move it to the camel-website from the 
beginning. I'll try to publish the layout there, and also the final bundle so I 
can link it from here (if possible with the new Apache rules for Githu 
Actions...)
   > 
   > If at all possible do not add another UI bundle to the camel-website, 
there are a number of optimizations that went into the apache-camel-ui UI 
bundle in the camel-website repository that you'll need to repeat in the second 
bundle. Adding changes to the existing apache-camel-ui UI bundle should be 
preferred.
   > 
   > This also maintains the separation of presentation vs content we have 
between the camel-website and other git repositories we pull to build the 
website.
   > 
   > Not sure about the Netlify integration, this is already present on the 
camel-website repository.
   > 
   > If you wish trigger publishing of changes made here to the website, that 
needs to happen with the trigger to the 
[Camel.website](https://ci-builds.apache.org/job/Camel/job/Camel.website/) job 
on the ASF Jenkins. Automating that could be done via a generic webhook on push 
to this repository (would require a secret to be added by INFRA).
   
   It wasn't my intention.. I kept changes separated into a bunch of files to 
merge them: https://github.com/apache/camel-website/pull/536
   
   I managed to display this catalog with the website UI with that change:
   
   ![Screenshot from 2021-02-11 
13-13-15](https://user-images.githubusercontent.com/4151857/107635153-f8b6e100-6c6a-11eb-85c4-0835c1c094cd.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to