Hi David, On Sun, Aug 29, 2021 at 10:20 AM David Jencks <david.a.jen...@gmail.com> wrote: > The current source state is now visible.
First of all, thank you this is a herculean effort, and I think it'll help us tremendously! > - I npm-published my asciidoctor-jsonpath extension > - The site content changes are at https://github.com/djencks/camel.git > jsonpath-options branch. I’ve put all the generated changes as the last > commit, so it should be possible to update the branch by dropping the last > commit, rebasing on main, and regenerating the source with the maven build. > - The camel-website changes are at > https://github.com/djencks/camel-website.git issue-16854-jsonpath-options > branch > > There’s a PR https://github.com/apache/camel-website/pull/614. I'm going through the PRs with the intent on getting them merged soon! > I don’t understand what the patch-sitemap.js does and was having dependency > problems so removed it from the command line. What does it do and why? Anotora can either generate absolute URLs in rendered HTML files and the sitemap XML files, or relative URLs in rendered HTML files without generating the sitemap XML files. We want the sitemap XML files for search engine integration and we want relative URLs for the link checker to work. That bit monkey patches Antora to have relative URLs in rendered HTML files and still generate the sitemap XML files. An alternative to monkey patching Antora was suggested on #772[1] that I haven't investigated fully but I'm sure it'll work. > The PR’s build fails because of missing ui bundle. Is this expected? I like > to have the built UI bundle available somewhere: I often check in the built > bundle. Locally I can’t build the UI, it complains somehow about the helpers > for component sorting/hiding. I will double check this. > I set up the build to fail on warnings, and there are quite a few warnings. I also saw that you fixed a number of missing attribute warnings, we'll need to keep an eye out for those, previously with Antora 2 it was a bit difficult to track those down, hopefully the new error/warning messages in Antora 3 will help with that. > There are several source problems I don’t know the proper fix for as it > requires domain knowledge. One is these warnings: > > [00:47:14.821] WARN (asciidoctor): skipping reference to missing attribute: > apisyntax > file: > docs/components/modules/ROOT/pages/google-calendar-stream-component.adoc > source: https://github.com/djencks/camel.git (refname: jsonpath-options, > start path: docs/components) > [00:47:15.979] WARN (asciidoctor): skipping reference to missing attribute: > apisyntax > file: docs/components/modules/ROOT/pages/google-mail-stream-component.adoc > source: https://github.com/djencks/camel.git (refname: jsonpath-options, > start path: docs/components) > [00:47:16.442] WARN (asciidoctor): skipping reference to missing attribute: > apisyntax > file: > docs/components/modules/ROOT/pages/google-sheets-stream-component.adoc > source: https://github.com/djencks/camel.git (refname: jsonpath-options, > start path: docs/components) I'm assuming these come from here: https://github.com/apache/camel/blob/b7c12e6f2d63fdd6e88f6534b5d226103ab80328/tooling/maven/camel-package-maven-plugin/src/main/resources/endpoint-options.mvel#L40 And that escaping would fix it... > These three components are missing an apisyntax entry in their json files. > The problem shows up in the current site as the literal string ’null’. > > There are some inconsistencies and mysteries in the gulpfile.js. I’ve > commented on some. I'll reflect on those as well > It would be great to know if anyone else can build the site from the PR > branch. I'll report here if I can build and run the checks... zoran [1] https://gitlab.com/antora/antora/-/issues/772 -- Zoran Regvart
