Hi David, working through the changes and emails, some more comments here...
On Fri, Sep 3, 2021 at 8:21 AM David Jencks <david.a.jen...@gmail.com> wrote: > comments: > > - I removed the patch-sitemap.js use. I can’t figure out why this is needed. > If it really is needed, it should be done with a pipeline extension. I think we'll need to restore this, otherwise we'll lose the sitemap generation which in turn leaves us with outdated links on the search engines, and as we change the links when we add or remove new documentation versions this becomes an issue. > - yarn workspace —topological-dev is not building the UI before it’s used. > I can’t figure out why; it is for other PRs. I replaced this by just calling > the UI build directly. That's odd, I did not notice this issue before, I'll try to reproduce it and see if there is something we can do about this, this should be one of the benefits in using workspaces. > - If nothing else is using the model building in UpdateReadmeMojo it can > probably be simplified further. >From what I understand we only need the JSON files generated now, perhaps the we don't need the UpdateReadmeMojo at all any more? > - The camel-website node dependencies have changed dramatically. It looks > like the yarn cache is checked into git; I haven’t checked in the changes. > Should I? Yes, we have a check in the CI that makes sure the cache is correct. > known problems: > > - When the first row contains a description with a list, the list isn’t > rendered properly. cf. > https://pr-614--camel.netlify.app/components/latest/activemq-component.html#_path_parameters_2_parameters > > <https://pr-614--camel.netlify.app/components/latest/activemq-component.html#_path_parameters_2_parameters> I guess this is fixed now, looks okay to me... > - All the names in the generated tables have ids so they can be linked to but > there’s no easy way to find out the id. The sections have a link to > themselves which makes it easy to copy the URL. I haven’t looked into > whether this can be done with the table entries. I think this is a nice to have, so we can definitely merge this without this and followup after... > Updating the main PR to track changes in camel is somewhat time consuming so > I’d appreciate it if we could move this towards resolution quickly. Yes, I'm looking into this right now, my goal is to get this merged _very_ soon! zoran -- Zoran Regvart
