Overall I like the gulp file changes, I left one comment. I discovered another anomaly you might like to investigate: Is components/camel-disruptor/src/main/docs/disruptor-vm-component.adoc supposed to exist? It doesn’t appear to have a json file for properties etc, and it’s rendering in the current site looks slightly odd (with the empty “Options” section).
Thanks! David Jencks > On Sep 9, 2021, at 8:15 AM, Zoran Regvart <zo...@regvart.com> wrote: > > Hi David & Cameleers, > I've made some progress in the main Camel repository focusing on the > Gulp tasks to generate symlinks and maintain nav.adoc files. Much > inspired by the work David did on the JSON files and trying to > generate Gulp tasks from data rather than having multiple, mostly > same, functionality in separate Gulp function tasks. This is still > very much a work in progress and a bit clunky at the moment, so I did > not create a PR at this time. But if someone wishes to have a look at > how this is shaping up, the code is here: > > https://github.com/zregvart/camel/commit/f753ed1099a5b93c4c5880f7ee220a20d66bdb58 > > I'll rework that much more later today/tomorrow. Again the focus, > right now is to use symbolic links instead of copying .adoc files and > to simplify the Gulp build by having it data driven, hopefully this > will make it easier to maintain in the future. > > I've found the same issues David did, so the comments David left in > the PR #6040[1] still stand -- we're working around some > inconsistencies in location and naming of .adoc files, look for > FIXME/IMPORTANT comments in gulpfile.js. I'll try to resolve those so > we don't carry too much baggage forward, and I might have some more > questions later. > > I've also prepared a bit (still incomplete) the second part of David's > changes, to get the component/endpoint option tables generated from > generated catalog JSON files, I think that I'll split that off into > two changes one for Gulp refactoring & symlinks and another for that. > > Again, very much a work in progress so feedback at this stage is very > welcome... > > zoran > > [1] https://github.com/apache/camel/pull/6040 > -- > Zoran Regvart
