Not a problem. I believe this was the last issue found in the SB code.
On Wed, Feb 1, 2023 at 10:38 AM Claus Ibsen <claus.ib...@gmail.com> wrote: > > On Wed, Feb 1, 2023 at 10:14 AM Gregor Zurowski <gre...@list.zurowski.org> > wrote: > > > And another candidate, the XStream starter: > > https://github.com/apache/camel-spring-boot/pull/727 > > > > > Thanks Gregor. Sorry for not have removed those beforehand. If you > encounter more mistakes then feel free to remove them without reviews. > > > > > > On Tue, Jan 31, 2023 at 10:31 PM Claus Ibsen <claus.ib...@gmail.com> > > wrote: > > > > > > tir. 31. jan. 2023 kl. 21.08 skrev Gregor Zurowski < > > gre...@list.zurowski.org > > > >: > > > > > > > I assume the same applies for camel-spring-integration? > > > > > > > > https://github.com/apache/camel-spring-boot/pull/725 > > > > > > > > > > yes > > > > > > > > > > On Tue, Jan 31, 2023 at 7:41 PM Claus Ibsen <claus.ib...@gmail.com> > > wrote: > > > > > > > > > > Hi > > > > > > > > > > Try cherry-pick this commit > > > > > > > > > > > https://github.com/apache/camel-spring-boot/commit/6e43ab4094bb6eb130228df4064e05947b4981b2 > > > > > > > > > > > > > > > On Tue, Jan 31, 2023 at 7:35 PM Claus Ibsen <claus.ib...@gmail.com> > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jan 31, 2023 at 7:29 PM Gregor Zurowski < > > > > gre...@list.zurowski.org> > > > > > > wrote: > > > > > > > > > > > >> I could complete the Camel build, but having issues with the > > Spring > > > > > >> Boot part. I am getting the following error: > > > > > >> > > > > > >> ``` > > > > > >> [ERROR] Failed to execute goal on project camel-rabbitmq-starter: > > > > > >> Could not resolve dependencies for project > > > > > >> > > org.apache.camel.springboot:camel-rabbitmq-starter:jar:4.0.0-SNAPSHOT: > > > > > >> Could not find artifact > > org.apache.camel:camel-rabbitmq:jar:4.0.0-M1 > > > > > >> in central (https://repo.maven.apache.org/maven2) -> [Help 1] > > > > > >> ``` > > > > > >> > > > > > >> The following dependency seems to be the culprit as it doesn't > > exist > > > > > >> anymore: > > > > > >> > > > > > > https://github.com/apache/camel-spring-boot/blob/main/components-starter/camel-rabbitmq-starter/pom.xml#L39 > > > > > >> > > > > > >> > > > > > > Ah thanks, yeah we need to remove that -starter as its been > > removed. > > > > > > Let me do that on main, and then you can cherry pick a commit hash > > > > > > > > > > > > > > > > > > > > > > > >> On Tue, Jan 31, 2023 at 10:05 AM Gregor Zurowski > > > > > >> <gre...@list.zurowski.org> wrote: > > > > > >> > > > > > > >> > Thanks a lot, taking a look now. > > > > > >> > > > > > > >> > On Tue, Jan 31, 2023 at 9:54 AM Otavio Rodolfo Piske > > > > > >> > <angusyo...@gmail.com> wrote: > > > > > >> > > > > > > > >> > > Sure thing, thanks! I've just merged it ... hopefully it will > > > > unblock > > > > > >> the > > > > > >> > > release. > > > > > >> > > > > > > > >> > > On Tue, Jan 31, 2023 at 9:50 AM Andrea Cosentino < > > > > anco...@gmail.com> > > > > > >> wrote: > > > > > >> > > > > > > > >> > > > Since it's just for the release side, I would merge, so > > Gregor > > > > could > > > > > >> > > > cherry-pick and we could go ahead with releasing. > > > > > >> > > > > > > > > >> > > > Il giorno mar 31 gen 2023 alle ore 09:49 Otavio Rodolfo > > Piske < > > > > > >> > > > angusyo...@gmail.com> ha scritto: > > > > > >> > > > > > > > > >> > > > > Hello, > > > > > >> > > > > > > > > > >> > > > > Folks, do you mind a look at this one? > > > > > >> > > > > https://github.com/apache/camel/pull/9269 > > > > > >> > > > > > > > > > >> > > > > I think this should correctly override the test execution > > > > during > > > > > >> release. > > > > > >> > > > > > > > > > >> > > > > Kind regards > > > > > >> > > > > > > > > > >> > > > > On Tue, Jan 31, 2023 at 9:20 AM Otavio Rodolfo Piske < > > > > > >> > > > angusyo...@gmail.com > > > > > >> > > > > > > > > > > >> > > > > wrote: > > > > > >> > > > > > > > > > >> > > > > > Thanks Gregor. I am looking at it. > > > > > >> > > > > > > > > > > >> > > > > > On Mon, Jan 30, 2023 at 4:56 PM Gregor Zurowski < > > > > > >> > > > > gre...@list.zurowski.org> > > > > > >> > > > > > wrote: > > > > > >> > > > > > > > > > > >> > > > > >> I cherry-picked your changes, but unfortunately the > > > > > >> integration tests > > > > > >> > > > > >> for camel-kafka are still getting executed. > > > > > >> > > > > >> > > > > > >> > > > > >> On Mon, Jan 30, 2023 at 1:43 PM Otavio Rodolfo Piske > > > > > >> > > > > >> <angusyo...@gmail.com> wrote: > > > > > >> > > > > >> > > > > > > >> > > > > >> > Hello, thanks Gregor. > > > > > >> > > > > >> > > > > > > >> > > > > >> > For camel-kafka, I think this should do the trick: > > > > > >> > > > > >> > https://github.com/apache/camel/pull/9253. I believe > > > > we'll > > > > > >> need to > > > > > >> > > > > >> > cherry-pick it. > > > > > >> > > > > >> > > > > > > >> > > > > >> > Kind regards > > > > > >> > > > > >> > > > > > > >> > > > > >> > On Mon, Jan 30, 2023 at 1:01 PM Gregor Zurowski < > > > > > >> > > > > >> gre...@list.zurowski.org> > > > > > >> > > > > >> > wrote: > > > > > >> > > > > >> > > > > > > >> > > > > >> > > I have found two issues so far: > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > 1) camel-kafka is executing integration tests (and > > > > fails) > > > > > >> with the > > > > > >> > > > > >> > > "release" profile active. This seems to be caused > > by > > > > this > > > > > >> Maven > > > > > >> > > > > >> > > configuration: > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > https://github.com/apache/camel/blob/main/components/camel-kafka/pom.xml#L139 > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > 2) camel-archetype-component is executing > > integration > > > > > >> tests (and > > > > > >> > > > > >> > > fails) with the "release" profile active. Not sure > > how > > > > it's > > > > > >> > > > supposed > > > > > >> > > > > >> > > to get disabled, there is the following > > configuration, > > > > but > > > > > >> it > > > > > >> > > > > doesn't > > > > > >> > > > > >> > > seem to be effective: > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > > > >> https://github.com/apache/camel/blob/main/archetypes/pom.xml#L83 > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > I guess it's worth fixing the root cause of this > > > > besides > > > > > >> disabling > > > > > >> > > > > >> > > integration tests in the release profile. The root > > > > causes > > > > > >> seems to > > > > > >> > > > > be > > > > > >> > > > > >> > > the JUnit 4 import here: > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > https://github.com/apache/camel/blob/main/archetypes/camel-archetype-component/src/main/resources/archetype-resources/src/test/java/__name__ComponentTest.java#L21 > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > Thanks, > > > > > >> > > > > >> > > Gregor > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > On Sun, Jan 29, 2023 at 8:21 PM Andrea Cosentino < > > > > > >> > > > anco...@gmail.com > > > > > >> > > > > > > > > > > >> > > > > >> > > wrote: > > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > > It won't move on Karaf as the vote has been > > aborted > > > > for > > > > > >> vetos. > > > > > >> > > > But > > > > > >> > > > > >> it > > > > > >> > > > > >> > > will > > > > > >> > > > > >> > > > be best effort. If someone have time/will to > > align to > > > > > >> camel 4.x > > > > > >> > > > we > > > > > >> > > > > >> will > > > > > >> > > > > >> > > > consider it again, but always as an additional > > > > release > > > > > >> not with > > > > > >> > > > > >> core and > > > > > >> > > > > >> > > Sb. > > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > > For too much time camel-karaf has been > > maintained by > > > > the > > > > > >> same > > > > > >> > > > two > > > > > >> > > > > >> > > people. I > > > > > >> > > > > >> > > > don't have the time anymore > > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > > Il dom 29 gen 2023, 19:55 Gregor Zurowski < > > > > > >> > > > > gre...@list.zurowski.org> > > > > > >> > > > > >> ha > > > > > >> > > > > >> > > > scritto: > > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > > > Still building Camel, but already pushed up > > > > > >> `release/4.0.0-M1` > > > > > >> > > > > >> > > > > branches on both camel and camel-spring-boot > > > > > >> repositories, so > > > > > >> > > > > >> everyone > > > > > >> > > > > >> > > > > can continue to commit on `main`. As far as I > > > > > >> understood from > > > > > >> > > > > >> previous > > > > > >> > > > > >> > > > > discussions, we are not releasing camel-karaf > > as > > > > part > > > > > >> of a 4.x > > > > > >> > > > > >> release > > > > > >> > > > > >> > > > > as it moves over to Karaf? > > > > > >> > > > > >> > > > > > > > > > >> > > > > >> > > > > Thanks, > > > > > >> > > > > >> > > > > Gregor > > > > > >> > > > > >> > > > > > > > > > >> > > > > >> > > > > On Sun, Jan 29, 2023 at 7:33 PM Gregor Zurowski > > > > > >> > > > > >> > > > > <gre...@list.zurowski.org> wrote: > > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > Thanks Andrea, it worked. I had previously > > > > provided > > > > > >> it via > > > > > >> > > > the > > > > > >> > > > > >> > > command > > > > > >> > > > > >> > > > > > line for testing (using `-D > > > > > >> > > > > >> Dsurefire.failIfNoSpecifiedTests=false`) > > > > > >> > > > > >> > > > > > without success. > > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > I am currently running through the `prepare` > > > > phase > > > > > >> with Java > > > > > >> > > > > 17 > > > > > >> > > > > >> and > > > > > >> > > > > >> > > > > > will let you know if I run into any other > > issues. > > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > Thanks for your help. > > > > > >> > > > > >> > > > > > Gregor > > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > On Sun, Jan 29, 2023 at 6:51 PM Andrea > > Cosentino > > > > < > > > > > >> > > > > >> anco...@gmail.com> > > > > > >> > > > > >> > > > > wrote: > > > > > >> > > > > >> > > > > > > > > > > > >> > > > > >> > > > > > > Let us know and thanks Gregor > > > > > >> > > > > >> > > > > > > > > > > > >> > > > > >> > > > > > > Il giorno dom 29 gen 2023 alle ore 18:50 > > Andrea > > > > > >> Cosentino > > > > > >> > > > < > > > > > >> > > > > >> > > > > anco...@gmail.com> > > > > > >> > > > > >> > > > > > > ha scritto: > > > > > >> > > > > >> > > > > > > > > > > > >> > > > > >> > > > > > > > I pushed a possible fix. > > > > > >> > > > > >> > > > > > > > > > > > > >> > > > > >> > > > > > > > Il giorno dom 29 gen 2023 alle ore 18:16 > > > > Andrea > > > > > >> > > > Cosentino > > > > > >> > > > > < > > > > > >> > > > > >> > > > > > > > anco...@gmail.com> ha scritto: > > > > > >> > > > > >> > > > > > > > > > > > > >> > > > > >> > > > > > > >> I think it needs to be set as false in > > the > > > > > >> surefire > > > > > >> > > > > >> > > configuration. > > > > > >> > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > > > >> Il dom 29 gen 2023, 17:36 Gregor > > Zurowski < > > > > > >> > > > > >> > > gre...@list.zurowski.org> > > > > > >> > > > > >> > > > > ha > > > > > >> > > > > >> > > > > > > >> scritto: > > > > > >> > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > > > >>> I am getting the following error early > > on > > > > when > > > > > >> > > > preparing > > > > > >> > > > > >> the > > > > > >> > > > > >> > > > > release: > > > > > >> > > > > >> > > > > > > >>> > > > > > >> > > > > >> > > > > > > >>> ``` > > > > > >> > > > > >> > > > > > > >>> [ERROR] Failed to execute goal > > > > > >> > > > > >> > > > > > > >>> > > > > > >> > > > > >> > > > > org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M8:test > > > > > >> > > > > >> > > > > > > >>> (default-test) on project > > > > camel-tooling-util: > > > > > >> No tests > > > > > >> > > > > >> matching > > > > > >> > > > > >> > > > > > > >>> pattern "false" were executed! (Set > > > > > >> > > > > >> > > > > > > >>> > > -Dsurefire.failIfNoSpecifiedTests=false to > > > > > >> ignore this > > > > > >> > > > > >> error.) > > > > > >> > > > > >> > > -> > > > > > >> > > > > >> > > > > > > >>> [Help 1] > > > > > >> > > > > >> > > > > > > >>> ``` > > > > > >> > > > > >> > > > > > > >>> > > > > > >> > > > > >> > > > > > > >>> Any idea what is causing this? > > > > > >> > > > > >> > > > > > > >>> > > > > > >> > > > > >> > > > > > > >>> Thanks in advance > > > > > >> > > > > >> > > > > > > >>> Gregor > > > > > >> > > > > >> > > > > > > >>> > > > > > >> > > > > >> > > > > > > >>> On Sun, Jan 29, 2023 at 4:20 PM Claus > > > > Ibsen < > > > > > >> > > > > >> > > claus.ib...@gmail.com > > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > >>> wrote: > > > > > >> > > > > >> > > > > > > >>> > > > > > > >> > > > > >> > > > > > > >>> > Hi > > > > > >> > > > > >> > > > > > > >>> > > > > > > >> > > > > >> > > > > > > >>> > Okay there was an issue in SB we > > have not > > > > > >> migrated > > > > > >> > > > one > > > > > >> > > > > >> of the > > > > > >> > > > > >> > > > > starters > > > > > >> > > > > >> > > > > > > >>> so I > > > > > >> > > > > >> > > > > > > >>> > had to remove it > > > > > >> > > > > >> > > > > > > >>> > > > > > > >> https://issues.apache.org/jira/browse/CAMEL-18984 > > > > > >> > > > > >> > > > > > > >>> > > > > > > >> > > > > >> > > > > > > >>> > Both branches now compiles with empty > > > > maven > > > > > >> repo and > > > > > >> > > > > >> pass CS > > > > > >> > > > > >> > > and > > > > > >> > > > > >> > > > > RAT > > > > > >> > > > > >> > > > > > > >>> checks. > > > > > >> > > > > >> > > > > > > >>> > > > > > > >> > > > > >> > > > > > > >>> > > > > > > >> > > > > >> > > > > > > >>> > On Sat, Jan 28, 2023 at 7:18 PM > > Gregor > > > > > >> Zurowski < > > > > > >> > > > > >> > > > > > > >>> gre...@list.zurowski.org> > > > > > >> > > > > >> > > > > > > >>> > wrote: > > > > > >> > > > > >> > > > > > > >>> > > > > > > >> > > > > >> > > > > > > >>> > > I will start taking a look > > tomorrow and > > > > > >> post > > > > > >> > > > > updates. > > > > > >> > > > > >> > > > > > > >>> > > > > > > > >> > > > > >> > > > > > > >>> > > Thanks, > > > > > >> > > > > >> > > > > > > >>> > > Gregor > > > > > >> > > > > >> > > > > > > >>> > > > > > > > >> > > > > >> > > > > > > >>> > > On Sat, Jan 28, 2023, 8:53 AM Claus > > > > Ibsen < > > > > > >> > > > > >> > > > > claus.ib...@gmail.com> > > > > > >> > > > > >> > > > > > > >>> wrote: > > > > > >> > > > > >> > > > > > > >>> > > > > > > > >> > > > > >> > > > > > > >>> > > > Hi > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > >> > > > > >> > > > > > > >>> > > > The core and SB branches are > > looking > > > > > >> good for > > > > > >> > > > the > > > > > >> > > > > >> > > 4.0.0-M1 > > > > > >> > > > > >> > > > > release. > > > > > >> > > > > >> > > > > > > >>> > > > I think we should cut the > > release at > > > > the > > > > > >> first > > > > > >> > > > > given > > > > > >> > > > > >> > > > > opportunity. > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > >> > > > > >> > > > > > > >>> > > > Gregor, you need to use Java 17 > > to > > > > build > > > > > >> the > > > > > >> > > > > release > > > > > >> > > > > >> > > (core > > > > > >> > > > > >> > > > > and SB > > > > > >> > > > > >> > > > > > > >>> > > > branches). > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > >> > > > > >> > > > > > > >>> > > > On Mon, Jan 23, 2023 at 7:37 AM > > Claus > > > > > >> Ibsen < > > > > > >> > > > > >> > > > > claus.ib...@gmail.com > > > > > >> > > > > >> > > > > > > >>> > > > > > > >> > > > > >> > > > > > > >>> > > wrote: > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > >> > > > > >> > > > > > > >>> > > > > Hi > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > > >> > > > > >> > > > > > > >>> > > > > I think it would be good if we > > can > > > > get > > > > > >> ready > > > > > >> > > > to > > > > > >> > > > > >> cut the > > > > > >> > > > > >> > > > > first > > > > > >> > > > > >> > > > > > > >>> milestone > > > > > >> > > > > >> > > > > > > >>> > > > > for Camel v4. > > > > > >> > > > > >> > > > > > > >>> > > > > As it's a new major version > > and a > > > > lot > > > > > >> of > > > > > >> > > > > >> development > > > > > >> > > > > >> > > then > > > > > >> > > > > >> > > > > we may > > > > > >> > > > > >> > > > > > > >>> have > > > > > >> > > > > >> > > > > > > >>> > > > some > > > > > >> > > > > >> > > > > > > >>> > > > > troubles" with cutting the > > release > > > > so > > > > > >> it would > > > > > >> > > > > be > > > > > >> > > > > >> good > > > > > >> > > > > >> > > to > > > > > >> > > > > >> > > > > try out > > > > > >> > > > > >> > > > > > > >>> > > sooner > > > > > >> > > > > >> > > > > > > >>> > > > > than later. > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > > >> > > > > >> > > > > > > >>> > > > > I will be on PTO this week, > > back at > > > > > >> weekend. > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > > >> > > > > >> > > > > > > >>> > > > > -- > > > > > >> > > > > >> > > > > > > >>> > > > > Claus Ibsen > > > > > >> > > > > >> > > > > > > >>> > > > > ----------------- > > > > > >> > > > > >> > > > > > > >>> > > > > @davsclaus > > > > > >> > > > > >> > > > > > > >>> > > > > Camel in Action 2: > > > > > >> > > > > https://www.manning.com/ibsen2 > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > >> > > > > >> > > > > > > >>> > > > -- > > > > > >> > > > > >> > > > > > > >>> > > > Claus Ibsen > > > > > >> > > > > >> > > > > > > >>> > > > ----------------- > > > > > >> > > > > >> > > > > > > >>> > > > @davsclaus > > > > > >> > > > > >> > > > > > > >>> > > > Camel in Action 2: > > > > > >> > > > https://www.manning.com/ibsen2 > > > > > >> > > > > >> > > > > > > >>> > > > > > > > > >> > > > > >> > > > > > > >>> > > > > > > > >> > > > > >> > > > > > > >>> > > > > > > >> > > > > >> > > > > > > >>> > > > > > > >> > > > > >> > > > > > > >>> > -- > > > > > >> > > > > >> > > > > > > >>> > Claus Ibsen > > > > > >> > > > > >> > > > > > > >>> > ----------------- > > > > > >> > > > > >> > > > > > > >>> > @davsclaus > > > > > >> > > > > >> > > > > > > >>> > Camel in Action 2: > > > > > >> https://www.manning.com/ibsen2 > > > > > >> > > > > >> > > > > > > >>> > > > > > >> > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > > >> > > > > >> > > > > > > >> > > > > >> > -- > > > > > >> > > > > >> > Otavio R. Piske > > > > > >> > > > > >> > http://orpiske.net > > > > > >> > > > > >> > > > > > >> > > > > > > > > > > >> > > > > > > > > > > >> > > > > > -- > > > > > >> > > > > > Otavio R. Piske > > > > > >> > > > > > http://orpiske.net > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > -- > > > > > >> > > > > Otavio R. Piske > > > > > >> > > > > http://orpiske.net > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > >> > > -- > > > > > >> > > Otavio R. Piske > > > > > >> > > http://orpiske.net > > > > > >> > > > > > > > > > > > > > > > > > > -- > > > > > > Claus Ibsen > > > > > > ----------------- > > > > > > @davsclaus > > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > > > > > > > > > > > > > -- > > > > > Claus Ibsen > > > > > ----------------- > > > > > @davsclaus > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > -- > > > Claus Ibsen > > > ----------------- > > > @davsclaus > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > -- > Claus Ibsen > ----------------- > @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2
