Thanks for making these changes. I now run into other issues with generated code:
``` [ERROR] Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.21.0:validate (validate) on project camel-avro-rpc: File '/git/camel/components/camel-avro-rpc/camel-avro-rpc-component/src/test/java/org/apache/camel/avro/generated/Value.java' has not been previously formatted. Please format file (for example by invoking `mvn -f components/camel-avro-rpc/camel-avro-rpc-component net.revelc.code.formatter:formatter-maven-plugin:2.21.0:format`) and commit before running validation! -> [Help 1] ``` Any ideas? Thanks, Gregor On Fri, Mar 24, 2023 at 12:36 PM Federico Mariani <federico.mariani.1...@gmail.com> wrote: > > In case there are no drawbacks, https://github.com/apache/camel/pull/9624 > > Il giorno ven 24 mar 2023 alle ore 12:33 Federico Mariani < > federico.mariani.1...@gmail.com> ha scritto: > > > Hello, seems like that the issue is with impsort-maven-plugin:1.6.0 and > > maven 3.9.0, updating the plugin to the latest version 1.8.0, the build of > > camel-util is successful, can I update the version, or you see any drawback > > in updating it? > > > > Il giorno ven 24 mar 2023 alle ore 12:01 Gregor Zurowski < > > gre...@list.zurowski.org> ha scritto: > > > >> Hi, > >> > >> While preparing the Camel 3.20.3 release, I am running into the following > >> issue: > >> > >> ``` > >> [ERROR] Failed to execute goal > >> net.revelc.code.formatter:formatter-maven-plugin:2.21.0:validate > >> (validate) on project camel-util: File > >> > >> '/git/camel/core/camel-util/src/main/java/org/apache/camel/util/SensitiveUtils.java' > >> has not been previously formatted. Please format file (for example by > >> invoking `mvn -f core/camel-util > >> net.revelc.code.formatter:formatter-maven-plugin:2.21.0:format`) and > >> commit before running validation! -> [Help 1] > >> ``` > >> > >> I already updated the Maven formatter plugin and reformatted all files > >> on the 3.20.x branch, but that didn't help. > >> > >> This is a generated file. Any ideas if there were any specific changes > >> made in regards to formatting? > >> > >> Thanks, > >> Gregor > >> > >> On Tue, Mar 21, 2023 at 11:45 AM Gregor Zurowski > >> <gre...@list.zurowski.org> wrote: > >> > > >> > Hi Claus, > >> > > >> > Sure, I will cut the release over the weekend. I have assigned > >> > https://issues.apache.org/jira/browse/CAMEL-19153 to myself and will > >> > update the dependencies once SB 2.7.10 is released. > >> > > >> > Thanks, > >> > Gregor > >> > > >> > On Tue, Mar 21, 2023 at 11:24 AM Claus Ibsen <claus.ib...@gmail.com> > >> wrote: > >> > > > >> > > Hi > >> > > > >> > > Gregor I wonder if you would have time friday or next week to cut the > >> > > 3.20.3 release. > >> > > We are waiting for Spring Boot 2.7.10 release which we need to upgrade > >> > > friday morning. > >> > > https://calendar.spring.io/ > >> > > > >> > > > >> > > > >> > > On Wed, Mar 8, 2023 at 9:16 AM Claus Ibsen <claus.ib...@gmail.com> > >> wrote: > >> > > > >> > > > Hi > >> > > > > >> > > > It would be good to get a new 3.20.3 release out later this month. > >> > > > > >> > > > There are some tickets still to work on. > >> > > > https://issues.apache.org/jira/projects/CAMEL/versions/12352884 > >> > > > > >> > > > > >> > > > > >> > > > -- > >> > > > Claus Ibsen > >> > > > ----------------- > >> > > > @davsclaus > >> > > > Camel in Action 2: https://www.manning.com/ibsen2 > >> > > > > >> > > > >> > > > >> > > -- > >> > > Claus Ibsen > >> > > ----------------- > >> > > @davsclaus > >> > > Camel in Action 2: https://www.manning.com/ibsen2 > >> > >
