Hi, On Mon, Jul 24, 2023 at 9:37 AM Nicolas Filotto <nfilo...@talend.com> wrote:
> Hi, > > I tend to agree with Claus, camel-test-infra should be used only for > integration tests for the reasons raised by Claus but also due to its name. > It would be really misleading for the community to have to depend on an > artifact called camel-test-infra for a unit test don't you agree? > Naming is hard ... So, yeah, maybe a better name could have prevented confusion. > In camel-test-junit5, Maybe we should do the same as what has been done in > camel-test-main-junit5 where developers can decide to either extend > CamelMainTestSupport or to use annotations like in SpringBoot and Quarkus > or simply move the core logic of camel-test-infra into camel-test-junit5 > and make camel-test-infra depends on camel-test-junit5, WDYT? > One problem, IMHO, camel-test-junit5 already has a dependency chain that is pretty complex, which is one of the things I wanted to solve ... But, more importantly, the problem is that I think it would be detrimental to Camel and the community to have 2 test approaches (one based on the CamelTestSupport and another based on the JUnit 5 extension), even if the code is reorganized within camel-test-junit5. I think it would also be detrimental to the features I hoped we would develop in the future: they would lack the maturity and stability from being extensively used to test Camel itself. Ultimately, without community consensus on the suggested approach, it would not attract contributions and would suffer too. To be clear ... I am not trying to be an inflexible contributor or hard headed person: I'd rather see my suggested feature (CAMEL-18957) go away than leave the codebase in a worse state ... And I'd love to discuss potential solutions that would allow us to develop those test features in the future. Kind regards > > Regards, > Nicolas > > > As a recipient of an email from the Talend Group, your personal data will > be processed by our systems. Please see our Privacy Notice < > https://www.talend.com/privacy-policy/> for more information about our > collection and use of your personal information, our security practices, > and your data protection rights, including any rights you may have to > object to automated-decision making or profiling we use to analyze support > or marketing related communications. To manage or discontinue promotional > communications, use the communication preferences portal< > https://info.talend.com/emailpreferencesen.html>. To exercise your data > protection rights, use the privacy request form< > https://talend.my.onetrust.com/webform/ef906c5a-de41-4ea0-ba73-96c079cdd15a/b191c71d-f3cb-4a42-9815-0c3ca021704cl>. > Contact us here <https://www.talend.com/contact/> or by mail to either of > our co-headquarters: Talend, Inc.: 400 South El Camino Real, Ste 1400, San > Mateo, CA 94402; Talend SAS: 5/7 rue Salomon De Rothschild, 92150 Suresnes, > France > -- Otavio R. Piske http://orpiske.net
