CAMEL-19862
Le 13/09/2023 à 12:16, Andrea Cosentino a écrit :
Hello,
I think we should log an issue for this, so we won't forget to double check
and fix.
Thanks.
Il giorno mer 13 set 2023 alle ore 12:11 Karen Lease <
karenlease...@gmail.com> ha scritto:
While working on the camel-examples which uses camel-dependencies, I
noticed a couple of things which surprised me in the generated content
of the camel-dependencies pom.xml.
1. The version of the apache pom is 25 but in the camel/pom.xml it's now
30. This comes from the template in the SyncProperties plugin.
2. None of the version properties in the camel/pom.xml are included due
to the filter used in the SyncPropertiesMojo:
camelPomXmlModel.getProperties().entrySet().stream()
.filter(property -> property.getKey().equals("mycila-license-version"))
Is this intentional? Most of the version properties in camel/pom.xml are
related to maven plugins. Those are hard-coded in the pluginManagement
section in version 25 of the Apache pom except for surefire.
In version 30 of the Apache pom the pluginManagement uses version
properties but they are not the same as the ones in the Camel pom.xml
(for example version.maven-compiler-plugin instead of
maven-compiler-plugin-version.)
The other version properties are related to jaxb and groovy.
Projects using camel-dependencies inherit the pluginManagement and
dependencyManagement from the Apache parent pom and not from Camel,
which can be confusing. That's especially true because the source
version of camel-dependencies/pom.xml has camel-parent as the parent
which seems to imply that it inherits more than just the properties.
Only by looking at the generated version does one see that this is not
the case.
I suggest we at least need to update the version of the Apache pom to be
consistent with Camel and we can remove the filter on
mycila-license-version which is no longer defined anywhere.
Cheers,
Karen
