Hi Claus, Thanks for the fix, I have cherry-picked 95174dc0 onto `release/4.1.0` and will try again.
Gregor On Sat, Oct 7, 2023 at 8:40 AM Claus Ibsen <claus.ib...@gmail.com> wrote: > > Hi > > Oh I have a possible fix (like we did in the core project) > > Notice how we use jar-no-fork instead of jar (we did something like that in > core to fix this kind of problem for 4.0.0) > https://github.com/apache/camel-spring-boot/pull/968 > > > On Sat, Oct 7, 2023 at 8:33 AM Claus Ibsen <claus.ib...@gmail.com> wrote: > > > > > > > On Fri, Oct 6, 2023 at 6:38 PM Gregor Zurowski <gre...@list.zurowski.org> > > wrote: > > > >> I am running into more plugin issues on the Spring Boot project. The > >> build fails early on camel-spring-boot-generator-maven-plugin: > >> > >> ``` > >> [ERROR] Failed to execute goal > >> org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork > >> (attach-sources) on project camel-spring-boot-generator-maven-plugin: > >> Presumably you have configured maven-source-plugn to execute twice > >> times in your build. You have to configure a classifier for at least > >> on of them. -> [Help 1] > >> ``` > >> > > > > Are you able to post here the command you run that triggers this error ? > > It would be good to know how we can reproduce this locally to help with > > resolving the issue. > > > > > > > >> > >> Will need to look more into this, but would appreciate your input if > >> you are familiar with this. > >> > >> Thanks again, > >> Gregor > >> > >> On Fri, Oct 6, 2023 at 12:25 PM Andrea Cosentino <anco...@gmail.com> > >> wrote: > >> > > >> > Yes, I would do that. I guess we need to address this stuff somewhat > >> > > >> > Il ven 6 ott 2023, 12:23 Gregor Zurowski <gre...@list.zurowski.org> ha > >> > scritto: > >> > > >> > > Thank you, Andrea, that helped. > >> > > > >> > > I am getting more such errors on the camel-restdsl-openapi-plugin: > >> > > ``` > >> > > [INFO] assert restdsl.exists() > >> > > [INFO] | | > >> > > [INFO] | false > >> > > [INFO] > >> > > > >> /git/camel/tooling/maven/camel-restdsl-openapi-plugin/target/it/simple-v3-yaml/target/generated-sources/restdsl-openapi/io/swagger/petstore/SwaggerPetstore.java > >> > > [INFO] > >> > > [INFO] [INFO] simple-v3-yaml/pom.xml > >> > > ........................... FAILED (1.260 s) > >> > > ``` > >> > > > >> > > Should I follow the same approach here? > >> > > > >> > > Thanks, > >> > > Gregor > >> > > > >> > > On Fri, Oct 6, 2023 at 11:42 AM Andrea Cosentino <anco...@gmail.com> > >> > > wrote: > >> > > > > >> > > > I think this is just a timing issue.. > >> > > > > >> > > > So I would skipt the integration-test in camel-package-maven-plugin > >> POM > >> > > by > >> > > > commenting > >> > > > > >> > > > <!--<goal>integration-test</goal>--> > >> > > > > >> > > > I think we need to review again how we are managing this stuff and > >> how to > >> > > > correctly tests. > >> > > > > >> > > > Il giorno ven 6 ott 2023 alle ore 11:28 Gregor Zurowski < > >> > > > gre...@list.zurowski.org> ha scritto: > >> > > > > >> > > > > Running into issues quite early in the build, specifically in the > >> > > > > Camel Maven Package module: > >> > > > > > >> > > > > ``` > >> > > > > [INFO] Running post-build script: > >> > > > > > >> > > > > > >> > > > >> /git/camel/tooling/maven/camel-package-maven-plugin/target/it/HeaderSupport/verify.groovy > >> > > > > [INFO] Assertion failed: > >> > > > > [INFO] > >> > > > > [INFO] assert json.exists() > >> > > > > [INFO] | | > >> > > > > [INFO] | false > >> > > > > [INFO] > >> > > > > > >> > > > >> /git/camel/tooling/maven/camel-package-maven-plugin/target/it/HeaderSupport/src/generated/resources/org/apache/camel/component/foo/foo.json > >> > > > > [...] > >> > > > > [INFO] [ERROR] The following builds failed: > >> > > > > [INFO] [ERROR] * HeaderSupport/pom.xml > >> > > > > [INFO] [INFO] ------------------------------------------------- > >> > > > > ``` > >> > > > > > >> > > > > Any ideas regarding this error? > >> > > > > > >> > > > > Thanks in advance > >> > > > > Gregor > >> > > > > > >> > > > > On Fri, Oct 6, 2023 at 11:05 AM Gregor Zurowski > >> > > > > <gre...@list.zurowski.org> wrote: > >> > > > > > > >> > > > > > I've pushed up `camel-4.1.x` and `camel-spring-boot-4.1.x` > >> > > > > > respectively. Once I finish a dry run, I will cut the release > >> > > branches > >> > > > > > and start. But either way, you are good to push to `main` again. > >> > > > > > > >> > > > > > On Fri, Oct 6, 2023 at 10:10 AM Gregor Zurowski > >> > > > > > <gre...@list.zurowski.org> wrote: > >> > > > > > > > >> > > > > > > Alright, I will cut the branches shortly. > >> > > > > > > > >> > > > > > > On Fri, Oct 6, 2023 at 9:24 AM Claus Ibsen < > >> claus.ib...@gmail.com> > >> > > > > wrote: > >> > > > > > > > > >> > > > > > > > Hi > >> > > > > > > > > >> > > > > > > > Okay the branch is ready for cutting the release. Good luck > >> > > Gregor. > >> > > > > > > > > >> > > > > > > > On Thu, Oct 5, 2023 at 3:14 PM Claus Ibsen < > >> > > claus.ib...@gmail.com> > >> > > > > wrote: > >> > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > On Thu, Oct 5, 2023 at 1:05 PM Claus Ibsen < > >> > > claus.ib...@gmail.com> > >> > > > > wrote: > >> > > > > > > > > > >> > > > > > > > >> Hi > >> > > > > > > > >> > >> > > > > > > > >> I am almost done. I need to do some sanity check on > >> jbang and > >> > > > > custom > >> > > > > > > > >> kamelet development. > >> > > > > > > > >> I will do this later today. If anything is really wrong > >> I will > >> > > > > get back > >> > > > > > > > >> here. > >> > > > > > > > >> > >> > > > > > > > >> Otherwise I think we are in good shape and the release > >> can be > >> > > cut > >> > > > > > > > >> tomorrow. > >> > > > > > > > >> > >> > > > > > > > >> > >> > > > > > > > > Okay all is good. We should be ready for cutting tomorrow. > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > >> > >> > > > > > > > >> > >> > > > > > > > >> On Tue, Oct 3, 2023 at 2:34 PM Andrea Cosentino < > >> > > > > anco...@gmail.com> > >> > > > > > > > >> wrote: > >> > > > > > > > >> > >> > > > > > > > >>> I completed that part this morning. > >> > > > > > > > >>> > >> > > > > > > > >>> +1 for me. > >> > > > > > > > >>> > >> > > > > > > > >>> Il giorno mar 3 ott 2023 alle ore 06:49 Andrea > >> Cosentino < > >> > > > > > > > >>> anco...@gmail.com> > >> > > > > > > > >>> ha scritto: > >> > > > > > > > >>> > >> > > > > > > > >>> > I just want to add a couple of thing to the jbang sbom > >> > > command > >> > > > > before > >> > > > > > > > >>> the > >> > > > > > > > >>> > release. > >> > > > > > > > >>> > > >> > > > > > > > >>> > I'll do this today or tomorrow and update the thread > >> once > >> > > done > >> > > > > > > > >>> > > >> > > > > > > > >>> > Thanks Gregor! > >> > > > > > > > >>> > > >> > > > > > > > >>> > Il lun 2 ott 2023, 19:50 Claus Ibsen < > >> > > claus.ib...@gmail.com> > >> > > > > ha > >> > > > > > > > >>> scritto: > >> > > > > > > > >>> > > >> > > > > > > > >>> >> On Mon, Oct 2, 2023 at 7:30 PM Gregor Zurowski < > >> > > > > > > > >>> gre...@list.zurowski.org> > >> > > > > > > > >>> >> wrote: > >> > > > > > > > >>> >> > >> > > > > > > > >>> >> > Now that all patch releases are out, I'd be able to > >> > > focus > >> > > > > on the 4.1 > >> > > > > > > > >>> >> > release. > >> > > > > > > > >>> >> > > >> > > > > > > > >>> >> > For 4.1, there's one ticket in progress, seven > >> still in > >> > > > > status "to > >> > > > > > > > >>> >> > do": > >> > > > > > > > >>> > >> > > https://issues.apache.org/jira/projects/CAMEL/versions/12353277. > >> > > > > > > > >>> >> > > >> > > > > > > > >>> >> > When is a good time to start? > >> > > > > > > > >>> >> > > >> > > > > > > > >>> >> > > >> > > > > > > > >>> >> There is still some things to finish up. > >> > > > > > > > >>> >> I wonder if thursday or friday (better) would work > >> for > >> > > you? > >> > > > > > > > >>> >> > >> > > > > > > > >>> >> > >> > > > > > > > >>> >> > >> > > > > > > > >>> >> > >> > > > > > > > >>> >> > Thanks, > >> > > > > > > > >>> >> > Gregor > >> > > > > > > > >>> >> > > >> > > > > > > > >>> >> > On Tue, Sep 26, 2023 at 9:09 AM Claus Ibsen < > >> > > > > claus.ib...@gmail.com> > >> > > > > > > > >>> >> wrote: > >> > > > > > > > >>> >> > > > >> > > > > > > > >>> >> > > Hi > >> > > > > > > > >>> >> > > > >> > > > > > > > >>> >> > > Thanks Gregor. I think it would be best to do the > >> > > release > >> > > > > before > >> > > > > > > > >>> your > >> > > > > > > > >>> >> > PTO. > >> > > > > > > > >>> >> > > So let's see if we can cut the release after all > >> the > >> > > patch > >> > > > > > > > >>> releases > >> > > > > > > > >>> >> have > >> > > > > > > > >>> >> > > been done. > >> > > > > > > > >>> >> > > > >> > > > > > > > >>> >> > > > >> > > > > > > > >>> >> > > On Mon, Sep 25, 2023 at 6:19 PM Gregor Zurowski < > >> > > > > > > > >>> >> > gre...@list.zurowski.org> > >> > > > > > > > >>> >> > > wrote: > >> > > > > > > > >>> >> > > > >> > > > > > > > >>> >> > > > +1 for me. I won't be available between > >> October 13 > >> > > and > >> > > > > October > >> > > > > > > > >>> 20, > >> > > > > > > > >>> >> but > >> > > > > > > > >>> >> > > > can work on the release either before or after > >> those > >> > > > > dates. > >> > > > > > > > >>> >> > > > > >> > > > > > > > >>> >> > > > > >> > > > > > > > >>> >> > > > On Sat, Sep 23, 2023 at 10:29 AM Claus Ibsen < > >> > > > > > > > >>> claus.ib...@gmail.com > >> > > > > > > > >>> >> > > >> > > > > > > > >>> >> > > > wrote: > >> > > > > > > > >>> >> > > > > > >> > > > > > > > >>> >> > > > > Hi > >> > > > > > > > >>> >> > > > > > >> > > > > > > > >>> >> > > > > I think it would be good to get 4.1 released > >> after > >> > > > > our patch > >> > > > > > > > >>> >> > releases. > >> > > > > > > > >>> >> > > > > > >> > > > > > > > >>> >> > > > > This will be a non LTS release but its good > >> > > baseline > >> > > > > for > >> > > > > > > > >>> follow up > >> > > > > > > > >>> >> > > > releases > >> > > > > > > > >>> >> > > > > where we can work on adding support for Java > >> 21 > >> > > that > >> > > > > is > >> > > > > > > > >>> planned > >> > > > > > > > >>> >> for > >> > > > > > > > >>> >> > the > >> > > > > > > > >>> >> > > > > next LTS by end of this year/early January. > >> > > > > > > > >>> >> > > > > > >> > > > > > > > >>> >> > > > > We may need a 4.2 non LTS also, before we > >> cut 4.3 > >> > > as > >> > > > > LTS. But > >> > > > > > > > >>> >> let's > >> > > > > > > > >>> >> > see > >> > > > > > > > >>> >> > > > > later what makes sense. > >> > > > > > > > >>> >> > > > > > >> > > > > > > > >>> >> > > > > Any thoughts? > >> > > > > > > > >>> >> > > > > > >> > > > > > > > >>> >> > > > > -- > >> > > > > > > > >>> >> > > > > Claus Ibsen > >> > > > > > > > >>> >> > > > > ----------------- > >> > > > > > > > >>> >> > > > > @davsclaus > >> > > > > > > > >>> >> > > > > Camel in Action 2: > >> https://www.manning.com/ibsen2 > >> > > > > > > > >>> >> > > > > >> > > > > > > > >>> >> > > > >> > > > > > > > >>> >> > > > >> > > > > > > > >>> >> > > -- > >> > > > > > > > >>> >> > > Claus Ibsen > >> > > > > > > > >>> >> > > ----------------- > >> > > > > > > > >>> >> > > @davsclaus > >> > > > > > > > >>> >> > > Camel in Action 2: > >> https://www.manning.com/ibsen2 > >> > > > > > > > >>> >> > > >> > > > > > > > >>> >> > >> > > > > > > > >>> >> > >> > > > > > > > >>> >> -- > >> > > > > > > > >>> >> Claus Ibsen > >> > > > > > > > >>> >> ----------------- > >> > > > > > > > >>> >> @davsclaus > >> > > > > > > > >>> >> Camel in Action 2: https://www.manning.com/ibsen2 > >> > > > > > > > >>> >> > >> > > > > > > > >>> > > >> > > > > > > > >>> > >> > > > > > > > >> > >> > > > > > > > >> > >> > > > > > > > >> -- > >> > > > > > > > >> Claus Ibsen > >> > > > > > > > >> ----------------- > >> > > > > > > > >> @davsclaus > >> > > > > > > > >> Camel in Action 2: https://www.manning.com/ibsen2 > >> > > > > > > > >> > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > -- > >> > > > > > > > > Claus Ibsen > >> > > > > > > > > ----------------- > >> > > > > > > > > @davsclaus > >> > > > > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > -- > >> > > > > > > > Claus Ibsen > >> > > > > > > > ----------------- > >> > > > > > > > @davsclaus > >> > > > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > >> > > > > > >> > > > >> > > > > > > -- > > Claus Ibsen > > ----------------- > > @davsclaus > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > -- > Claus Ibsen > ----------------- > @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2
