The changes work, I can proceed with the SB release. Thanks a lot! I have also merged your PR.
Thanks, Gregor On Mon, Sep 9, 2024 at 9:45 AM Gregor Zurowski <gre...@list.zurowski.org> wrote: > > The changes look good. I cherry-picked your commit onto the > `release/4.8.0` branch and am trying it now. > > On Mon, Sep 9, 2024 at 9:36 AM Claus Ibsen <claus.ib...@gmail.com> wrote: > > > > Hi Gregor > > > > I have a fix as a PR, can you try that > > https://github.com/apache/camel-spring-boot/pull/1213 > > > > On Mon, Sep 9, 2024 at 9:25 AM Gregor Zurowski <gre...@list.zurowski.org> > > wrote: > > > > > Yes, it's reproducible with: > > > > > > cd tooling/camel-spring-boot-config-generator-maven-plugin > > > ../../mvnw javadoc:javadoc > > > > > > Updating the maven-javadoc-plugin to 3.10.0 didn't help. > > > > > > On Mon, Sep 9, 2024 at 9:21 AM Claus Ibsen <claus.ib...@gmail.com> wrote: > > > > > > > > Hi > > > > > > > > Okay Gregor. > > > > > > > > I guess we can try to reproduce this doing a dryRun release. > > > > > > > > The command is something like this > > > > > > > > ./mvnw release:prepare -DdryRun -Prelease > > > > > > > > Or maybe just running mvn javadoc:javadoc triggers this > > > > > > > > On Mon, Sep 9, 2024 at 7:59 AM Gregor Zurowski <gre...@list.zurowski.org > > > > > > > > wrote: > > > > > > > > > Hi, > > > > > > > > > > The core project completed without issues, but I am running into the > > > > > following error when building the Spring Boot project: > > > > > > > > > > ``` > > > > > [ERROR] Failed to execute goal > > > > > org.apache.maven.plugins:maven-javadoc-plugin:3.4.1:jar > > > > > (attach-javadocs) on project > > > > > camel-spring-boot-config-generator-maven-plugin: MavenReportException: > > > > > Error while generating Javadoc: > > > > > [ERROR] Exit code: 2 - error: release version 7 not supported > > > > > [ERROR] 1 error > > > > > ``` > > > > > > > > > > Not sure where version 7 is coming from. The Javadoc plugin seems to > > > > > be configured the same way as in the core project. > > > > > > > > > > Any ideas? > > > > > > > > > > Thanks, > > > > > Gregor > > > > > > > > > > > > > > > On Sun, Sep 8, 2024 at 9:18 AM Gregor Zurowski < > > > gre...@list.zurowski.org> > > > > > wrote: > > > > > > > > > > > > Things are looking good so far. I'll probably finish cutting the RC > > > in > > > > > > the next few hours. > > > > > > > > > > > > On Sat, Sep 7, 2024 at 5:53 PM Gregor Zurowski < > > > gre...@list.zurowski.org> > > > > > wrote: > > > > > > > > > > > > > > Thanks for the updates. I will attempt a first build now and will > > > post > > > > > > > updates to this thread if I run into any issues. > > > > > > > > > > > > > > On Sat, Sep 7, 2024 at 9:25 AM Claus Ibsen <claus.ib...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > > > > Hi > > > > > > > > > > > > > > > > Okay all is ready. > > > > > > > > Gregor, you have the green light to do the release. Good luck. > > > > > > > > > > > > > > > > > > > > > > > > On Sat, Sep 7, 2024 at 8:54 AM Claus Ibsen < > > > claus.ib...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > > > > > Hi > > > > > > > > > > > > > > > > > > Okay I have a fix for > > > > > > > > > https://issues.apache.org/jira/browse/CAMEL-21185 > > > > > > > > > > > > > > > > > > In the works. I will report back when the branch is ready for > > > > > release. > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Sep 6, 2024 at 7:45 PM Andrea Cosentino < > > > anco...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > > > > > >> But everything is ready > > > > > > > > >> > > > > > > > > >> Il ven 6 set 2024, 19:43 Andrea Cosentino <anco...@gmail.com> > > > ha > > > > > scritto: > > > > > > > > >> > > > > > > > > >> > Not yet > > > > > > > > >> > > > > > > > > > >> > Il ven 6 set 2024, 19:42 Claus Ibsen > > > > > > > > >> > <claus.ib...@gmail.com> > > > ha > > > > > > > > >> scritto: > > > > > > > > >> > > > > > > > > > >> >> Hi > > > > > > > > >> >> > > > > > > > > >> >> Is Gregor working on the release? > > > > > > > > >> >> > > > > > > > > >> >> On Thu, Sep 5, 2024 at 5:29 PM Claus Ibsen < > > > > > claus.ib...@gmail.com> > > > > > > > > >> wrote: > > > > > > > > >> >> > > > > > > > > >> >> > Hi > > > > > > > > >> >> > > > > > > > > > >> >> > Okay so I have a last PR that will be merged later > > > > > > > > >> >> > today. > > > > > > > > >> >> > > > > > > > > > >> >> > I will be out of office tomorrow. So Andrea, Otavio et > > > all., > > > > > then > > > > > > > > >> make > > > > > > > > >> >> > sure the branch will be ready for releasing. > > > > > > > > >> >> > And report back here so Gregor knows he can start. > > > > > > > > >> >> > > > > > > > > > >> >> > On Thu, Sep 5, 2024 at 10:09 AM Claus Ibsen < > > > > > claus.ib...@gmail.com> > > > > > > > > >> >> wrote: > > > > > > > > >> >> > > > > > > > > > >> >> >> Hi > > > > > > > > >> >> >> > > > > > > > > >> >> >> Okay so last day today to get final fixes and what else > > > > > done. > > > > > > > > >> >> >> > > > > > > > > >> >> >> Take time to complete, move tickets that are assigned > > > for > > > > > 4.8 > > > > > > > > >> >> >> > > > > > > > > >> >> >> > > > > > > > > >> >> > > > > > > > > >> > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20CAMEL%20AND%20fixVersion%20%3D%204.8.0%20AND%20statusCategory%20%3D%20new > > > > > > > > >> >> >> > > > > > > > > >> >> >> > > > > > > > > >> >> >> > > > > > > > > >> >> >> On Tue, Sep 3, 2024 at 2:50 PM Claus Ibsen < > > > > > claus.ib...@gmail.com> > > > > > > > > >> >> wrote: > > > > > > > > >> >> >> > > > > > > > > >> >> >>> Hi > > > > > > > > >> >> >>> > > > > > > > > >> >> >>> Okay so we are doing the last changes on the main > > > branch > > > > > this work > > > > > > > > >> >> week. > > > > > > > > >> >> >>> It would be great if all work is done by friday > > > morning, > > > > > so Gregor > > > > > > > > >> has > > > > > > > > >> >> >>> the opportunity to build the release. > > > > > > > > >> >> >>> > > > > > > > > >> >> >>> The JIRA has a number of open tickets for 4.8. Take a > > > look > > > > > at > > > > > > > > >> those, > > > > > > > > >> >> and > > > > > > > > >> >> >>> move to 4.9 if they are not possible to get complete > > > this > > > > > week. > > > > > > > > >> >> >>> > > > > > > > > >> >> >>> > > > > > > > > >> >> >>> > > > > > > > > >> >> >>> On Tue, Aug 6, 2024 at 1:35 PM Gregor Zurowski < > > > > > > > > >> >> gre...@list.zurowski.org> > > > > > > > > >> >> >>> wrote: > > > > > > > > >> >> >>> > > > > > > > > >> >> >>>> Yes, I will be available for building the release on > > > the > > > > > weekend > > > > > > > > >> of > > > > > > > > >> >> >>>> September 7th/8th. > > > > > > > > >> >> >>>> > > > > > > > > >> >> >>>> On Tue, Aug 6, 2024 at 10:33 AM Claus Ibsen < > > > > > > > > >> claus.ib...@gmail.com> > > > > > > > > >> >> >>>> wrote: > > > > > > > > >> >> >>>> > > > > > > > > > >> >> >>>> > Hi > > > > > > > > >> >> >>>> > > > > > > > > > >> >> >>>> > I think it would be great if we can have a new 4.8 > > > LTS > > > > > release > > > > > > > > >> by > > > > > > > > >> >> >>>> start of > > > > > > > > >> >> >>>> > september. > > > > > > > > >> >> >>>> > That gives us about 3-4 weeks to make the code-base > > > > > ready. > > > > > > > > >> >> >>>> > > > > > > > > > >> >> >>>> > Gregor, would that work for you? > > > > > > > > >> >> >>>> > > > > > > > > > >> >> >>>> > -- > > > > > > > > >> >> >>>> > Claus Ibsen > > > > > > > > >> >> >>>> > ----------------- > > > > > > > > >> >> >>>> > @davsclaus > > > > > > > > >> >> >>>> > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > >> >> >>>> > > > > > > > > >> >> >>> > > > > > > > > >> >> >>> > > > > > > > > >> >> >>> -- > > > > > > > > >> >> >>> Claus Ibsen > > > > > > > > >> >> >>> ----------------- > > > > > > > > >> >> >>> @davsclaus > > > > > > > > >> >> >>> Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > >> >> >>> > > > > > > > > >> >> >> > > > > > > > > >> >> >> > > > > > > > > >> >> >> -- > > > > > > > > >> >> >> Claus Ibsen > > > > > > > > >> >> >> ----------------- > > > > > > > > >> >> >> @davsclaus > > > > > > > > >> >> >> Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > >> >> >> > > > > > > > > >> >> > > > > > > > > > >> >> > > > > > > > > > >> >> > -- > > > > > > > > >> >> > Claus Ibsen > > > > > > > > >> >> > ----------------- > > > > > > > > >> >> > @davsclaus > > > > > > > > >> >> > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > >> >> > > > > > > > > > >> >> > > > > > > > > >> >> > > > > > > > > >> >> -- > > > > > > > > >> >> Claus Ibsen > > > > > > > > >> >> ----------------- > > > > > > > > >> >> @davsclaus > > > > > > > > >> >> Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > >> >> > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > Claus Ibsen > > > > > > > > > ----------------- > > > > > > > > > @davsclaus > > > > > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Claus Ibsen > > > > > > > > ----------------- > > > > > > > > @davsclaus > > > > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > > > > > > > > > -- > > > > Claus Ibsen > > > > ----------------- > > > > @davsclaus > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > -- > > Claus Ibsen > > ----------------- > > @davsclaus > > Camel in Action 2: https://www.manning.com/ibsen2
