On Mon, Feb 10, 2025 at 12:19 AM Jean-Baptiste Onofré <j...@nanthrax.net>
wrote:
> Thanks Gregor.
>
> It's ok if dist.release is populated after the vote (usually we use
> dist.dev, that's why I was confused).
>
> +1 (binding)
>
> - hash and checksum are ok
> - LICENSE and NOTICE are not fully correct, but not release blocker:
> - LICENSE should mention mvnw/mvnw.cmd as it's copied from Maven
> - LICENSE should mention camel-netty SubnetUtils code copied from
> Commons Net
> - LICENSE should mention camel-netty DelimiterBasedFrameDecoder
> code copied from Netty Codec
> - LICENSE should mention camel-ai LangChain4jChatIT code copied
> from Langchain4j
> - LICENSE should mention camel-aws-xray KafkaSegmentDecorator code
> copied from Kafka
> - LICENSE should mention camel-olingo2-api ODataPathSegmentImpl,
> UriType and SystemQueryOption code copied from Olingo2
> - LICENSE should mention camel-util
> ClassLoadingAwareObjectInputStream code copied from ActiveMQ
> - NOTICE should be updated to reflect LICENSE (especially Netty NOTICE)
> - The source distribution contains a weird folder imho (e.g.
> ${sys:infinispan.server.log.path})
>
Yeah, I also noticed this wired folder and it looks like it was created
when running the test compiling of camel-infinispan-embedded. After some
investigating, I found that removing
org.infinispan:infinispan-commons:test-jar stops the creation of
${sys:infinispan.server.log.path}. Then I tried to check this test jar and
there is a log4j2-test.xml which contains the following property
<Configuration name="InfinispanTestConfig" monitorInterval="60"
shutdownHook="disable">
<Properties>
<Property name="path">${sys:infinispan.server.log.path}</Property>
...
It seems that during the compile phase, Maven might be loading such
configuration early and causing the directory to be created.
Since we have our own log4j2.properties, so it could be a workaround to
create src/test/resources/log4j2.component.properties which includes
"log4j2.configurationFile=log4j2.properties" to ignore log4j2-test.xml from
the infinispan-common test jar.
I just tested it locally and it seems to be working. Is there any better
solution?
- The source distribution doesn't contain unexpected binary file
> - ASF header are present in all expected file (rat should not exclude
> md, sh, etc as it's pretty simple to add ASF header in this kind of
> files)
> - I'm able to build from the source distribution
>
> I will create PRs for the next releases.
>
> Thanks
> Regards
> JB
>
> On Sun, Feb 9, 2025 at 11:06 AM Gregor Zurowski
> <gre...@list.zurowski.org> wrote:
> >
> > Hi JB,
> >
> > We usually publish the source packages once we close the vote. This is
> > done with this script:
> > https://github.com/apache/camel/blob/main/etc/scripts/release-distro.sh
> >
> > At the time of the vote, the sources are available in the staging
> > area:
> https://repository.apache.org/content/repositories/orgapachecamel-1794/org/apache/camel/apache-camel/4.10.0/
> >
> > I will update the wording for the vote email for the next release.
> >
> > Thanks,
> > Gregor
> >
> > On Sun, Feb 9, 2025 at 8:29 AM Jean-Baptiste Onofré <j...@nanthrax.net>
> wrote:
> > >
> > > Hi Gregor
> > >
> > > I don't find the source distributions on dist.apache.org.
> > > Do we have it ?
> > >
> > > It's required from an ASF standpoint.
> > >
> > > Note: https://www.apache.org/foundation/voting.html#ReleaseVotes it's
> > > not really possible to veto a release. I propose to update the wording
> > > for the next vote emails.
> > >
> > > Thanks!
> > > Regards
> > > JB
> > >
> > > On Fri, Feb 7, 2025 at 9:18 PM Gregor Zurowski <
> gre...@list.zurowski.org> wrote:
> > > >
> > > > Hi Everyone:
> > > >
> > > > This is a vote to release Apache Camel 4.10.0 (LTS), a new release
> > > > with 214 new features and improvements.
> > > >
> > > > Release notes:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12355134&projectId=12311211
> > > >
> > > > == Apache Camel 4.10.0 ==
> > > >
> > > > Staging repository:
> > > >
> https://repository.apache.org/content/repositories/orgapachecamel-1794/
> > > >
> > > > Tarballs:
> https://repository.apache.org/content/repositories/orgapachecamel-1794/org/apache/camel/apache-camel/4.10.0/
> > > >
> > > > Tag: https://github.com/apache/camel/releases/tag/camel-4.10.0
> > > >
> > > > == Apache Camel Spring Boot 4.10.0 ==
> > > >
> > > > Staging repository:
> > > >
> https://repository.apache.org/content/repositories/orgapachecamel-1795/
> > > >
> > > > Tag:
> https://github.com/apache/camel-spring-boot/releases/tag/camel-spring-boot-4.10.0
> > > >
> > > > Please test this release candidate and cast your vote:
> > > > [ ] +1 Release the binary as Apache Camel and Camel Spring Boot
> 4.10.0
> > > > [ ] -1 Veto the release (provide specific comments)
> > > > The vote is open for at least 72 hours.
> > > >
> > > > Thanks,
> > > > Gregor
>
>
