VenuReddy2103 commented on a change in pull request #4110: URL: https://github.com/apache/carbondata/pull/4110#discussion_r609295437
########## File path: integration/spark/src/main/scala/org/apache/carbondata/index/secondary/SecondaryIndex.java ########## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.carbondata.index.secondary; + +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; + +import org.apache.carbondata.common.logging.LogServiceFactory; +import org.apache.carbondata.core.datastore.block.SegmentProperties; +import org.apache.carbondata.core.index.IndexUtil; +import org.apache.carbondata.core.index.dev.IndexModel; +import org.apache.carbondata.core.index.dev.cgindex.CoarseGrainIndex; +import org.apache.carbondata.core.indexstore.Blocklet; +import org.apache.carbondata.core.metadata.schema.table.CarbonTable; +import org.apache.carbondata.core.scan.expression.Expression; +import org.apache.carbondata.core.scan.filter.executer.FilterExecutor; +import org.apache.carbondata.core.scan.filter.resolver.FilterResolverIntf; +import org.apache.carbondata.index.secondary.SecondaryIndexModel.PositionReferenceInfo; + +import org.apache.log4j.Logger; + +import static org.apache.carbondata.core.util.path.CarbonTablePath.BATCH_PREFIX; + +/** + * Secondary Index to prune at blocklet level. + */ +public class SecondaryIndex extends CoarseGrainIndex { + private static final Logger LOGGER = + LogServiceFactory.getLogService(SecondaryIndex.class.getName()); + String indexName; + String currentSegmentId; + List<String> validSegmentIds; + PositionReferenceInfo positionReferenceInfo; + + @Override + public void init(IndexModel indexModel) { + assert (indexModel instanceof SecondaryIndexModel); + SecondaryIndexModel model = (SecondaryIndexModel) indexModel; + indexName = model.indexName; + currentSegmentId = model.currentSegmentId; + validSegmentIds = model.validSegmentIds; + positionReferenceInfo = model.positionReferenceInfo; + } + + private Set<String> getPositionReferences(String databaseName, String indexName, + Expression expression) { + synchronized (positionReferenceInfo) { Review comment: have removed the synchronization block now with another review comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
