VenuReddy2103 commented on a change in pull request #4110:
URL: https://github.com/apache/carbondata/pull/4110#discussion_r610493428
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/expression/LiteralExpression.java
##########
@@ -58,7 +64,28 @@ public String getString() {
@Override
public String getStatement() {
- return value == null ? null : value.toString();
+ boolean quoteString = false;
+ Object val = value;
+ if (val != null) {
+ if (dataType == DataTypes.STRING || val instanceof String) {
+ quoteString = true;
+ } else if (dataType == DataTypes.TIMESTAMP) {
+ SimpleDateFormat parser =
+ new
SimpleDateFormat(CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT);
+ val = parser.format(new Date((Long) val / 1000L));
+ quoteString = true;
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
