ShreelekhyaG commented on a change in pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#discussion_r611629016
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAddLoadCommand.scala
##########
@@ -341,22 +350,6 @@ case class CarbonAddLoadCommand(
carbonTable, segment, partitionSpecOp.orNull,
partitionDataFiles.asJava)
}
- // This event will trigger merge index job, only trigger it if it is
carbon file
- if (isCarbonFormat) {
- operationContext.setProperty(
- carbonTable.getTableUniqueName + "_Segment",
- model.getSegmentId)
- // when this event is triggered, SI load listener will be called for all
the SI tables under
- // this main table, no need to load the SI tables for add load command,
so add this property
- // to check in SI load event listener to avoid loading to SI.
- operationContext.setProperty("isAddLoad", "true")
- val loadTablePreStatusUpdateEvent: LoadTablePreStatusUpdateEvent =
Review comment:
I'm directly calling mergeIndex( using
`mergeIndexFilesInAddLoadSegment`) here instead of the listener. So, no need of
setting `isAddLoadProperty`. And I have removed this property from SI listener
also.
##########
File path:
index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/mergeindex/CarbonIndexFileMergeTestCaseWithSI.scala
##########
@@ -246,19 +246,22 @@ class CarbonIndexFileMergeTestCaseWithSI
CarbonCommonConstants.DEFAULT_SEGMENT_LEVEL_THRESHOLD)
}
- private def getIndexFileCount(tableName: String, segment: String): Int = {
+ private def getIndexFileCount(tableName: String,
+ segment: String,
+ extension: String = CarbonTablePath.INDEX_FILE_EXT): Int = {
val table = CarbonMetadata.getInstance().getCarbonTable(tableName)
val path = CarbonTablePath
.getSegmentPath(table.getAbsoluteTableIdentifier.getTablePath, segment)
val carbonFiles = FileFactory.getCarbonFile(path).listFiles(new
CarbonFileFilter {
- override def accept(file: CarbonFile): Boolean =
file.getName.endsWith(CarbonTablePath
- .INDEX_FILE_EXT)
+ override def accept(file: CarbonFile): Boolean = {
+ file.getName.endsWith(CarbonTablePath.INDEX_FILE_EXT) ||
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
