akashrn5 commented on a change in pull request #4121:
URL: https://github.com/apache/carbondata/pull/4121#discussion_r620186410
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/AlterTableDropColumnEventListener.scala
##########
@@ -74,23 +73,11 @@ class AlterTableDropColumnEventListener extends
OperationEventListener {
val indexColumns =
indexTable._2.asScala(CarbonCommonConstants.INDEX_COLUMNS).split(",")
val colSize =
alterTableDropColumnModel.columns.intersect(indexColumns).size
if (colSize > 0) {
- if (colSize == indexColumns.size) {
- indexTableToDrop ++= Seq(indexTable._1)
- } else {
- sys
- .error(s"Index Table [${
- indexTable._1
- }] exists with combination of provided drop column(s) and other
columns, drop " +
- s"index table & retry")
- }
+ sys
+ .error(s"Index Table [${
+ indexTable._1
+ }] contains provided drop column(s), please drop index table &
retry")
}
})
- indexTableToDrop.foreach { indexTable =>
Review comment:
got the complete info with the offline discussion, so please check if
the documentation contains about it, if there please update if not, add a note
section for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
