ShreelekhyaG commented on a change in pull request #4098:
URL: https://github.com/apache/carbondata/pull/4098#discussion_r644526559
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/test/SparkTestQueryExecutor.scala
##########
@@ -82,6 +83,15 @@ object SparkTestQueryExecutor {
copyResourcesifNotExists(hdfsUrl,
s"$integrationPath/spark/src/test/resources",
s"$integrationPath//spark-common-cluster-test/src/test/resources/testdatafileslist.txt")
}
+ if (System.getProperty("useIndexServer") != null ||
System.getenv("useIndexServer") != null) {
Review comment:
ok
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/test/util/CarbonFunSuite.scala
##########
@@ -44,4 +44,18 @@ private[spark] abstract class CarbonFunSuite extends
FunSuite {
}
}
+ protected def test(testName : scala.Predef.String, ignoreForIndexServer:
Boolean,
+ testTags : org.scalatest.Tag*)
+ (testFun : => Unit): Unit = {
+ if (ignoreForIndexServer) {
+ if (System.getProperty("useIndexServer") == null) {
Review comment:
done
##########
File path:
integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexServer.scala
##########
@@ -50,6 +51,7 @@ trait ServerInterface {
/**
* Used to prune and cache the index for the table.
*/
+ @throws(classOf[IOException])
Review comment:
no need to ignore testcase as external carbon segments are pruned by
indexserver. non-carbon segments are not pruned. From `distributedPrunedRdd
`when async calls to prune are made, `TableIndex.prune` method throws
IOException and this is not handled in parent caller - `indexserver.getsplits`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
