ShreelekhyaG commented on a change in pull request #4142:
URL: https://github.com/apache/carbondata/pull/4142#discussion_r646533017
##########
File path:
integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/query/SecondaryIndexQueryResultProcessor.java
##########
@@ -277,15 +277,10 @@ private void processResult(List<CarbonIterator<RowBatch>>
detailQueryResultItera
CarbonDimension dims = dimensions.get(i);
boolean isComplexColumn = false;
// As complex column of MainTable is stored as its primitive type in SI,
- // we need to check if dimension is complex dimension or not based on
dimension
- // name. Check if name exists in complexDimensionInfoMap of main table
result
- if (!complexDimensionInfoMap.isEmpty() &&
complexColumnParentBlockIndexes.length > 0) {
- for (GenericQueryType queryType : complexDimensionInfoMap.values()) {
- if (queryType.getName().equalsIgnoreCase(dims.getColName())) {
- isComplexColumn = true;
- break;
- }
- }
+ // we need to check if dimension is complex dimension or not based on
isParentColumnComplex
+ // property.
+ if
(Boolean.parseBoolean(dims.getColumnProperties().get("isParentColumnComplex")))
{
Review comment:
Done
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/command/SICreationCommand.scala
##########
@@ -683,15 +683,18 @@ private[sql] case class CarbonCreateSecondaryIndexCommand(
// if data type is arrayType, then store the column as its CHILD data type
in SI
if (DataTypes.isArrayType(parentColumnSchema.getDataType)) {
columnSchema.setDataType(dataType)
+ val colPropMap = new java.util.HashMap[String, String]()
Review comment:
ok done
##########
File path:
integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/query/SecondaryIndexQueryResultProcessor.java
##########
@@ -294,25 +289,31 @@ private void processResult(List<CarbonIterator<RowBatch>>
detailQueryResultItera
preparedRow[i] = wrapper.getDictionaryKeyByIndex(dictionaryIndex++);
} else {
if (isComplexColumn) {
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
