kunal642 commented on a change in pull request #4186:
URL: https://github.com/apache/carbondata/pull/4186#discussion_r677534970
##########
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/deleteTable/TestDeleteTableNewDDL.scala
##########
@@ -58,6 +67,20 @@ class TestDeleteTableNewDDL extends QueryTest with
BeforeAndAfterAll {
}.getMessage.contains("Database 'dropdb_test' not found"))
}
+ test("test drop database when dblocation is inconsistent") {
+ var dbName = "dropdb_test"
+ sql(s"drop database if exists $dbName cascade")
+
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.STORE_LOCATION,
+ warehouse + File.separator + "carbonwarehouse")
+ sql(s"create database $dbName")
Review comment:
carbon.storeLocation is not deprecated right now.
I suggest the following changes
1. Deprecate the use of carbon.storeLocation(this property should be removed
in 3.0 release)
2. throw exception on database creation and deletion as suggested by
indhumathi.
3. Add a documentation point that if the user wants to delete the database
then store has to be migrated to "spark.sql.warehouse.dir"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
