[GitHub] [carbondata] Lior-AI commented on a change in pull request #4211: [WIP][CARBONDATA-4273] Fix Cannot create external table with partitions

[GitBox]

Lior-AI commented on a change in pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#discussion_r698015433



##########
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParserUtil.scala
##########
@@ -215,10 +215,6 @@ object CarbonSparkSqlParserUtil {
       table.identifier.table.toLowerCase()
     )
     val tableInfo = if (isExternal) {
-      if (partitionColumnNames.nonEmpty) {

Review comment:
       Why can we remove it?
   do we support this now?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org