kunal642 commented on a change in pull request #4218:
URL: https://github.com/apache/carbondata/pull/4218#discussion_r710778083
##########
File path:
integration/spark/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessorStepOnSpark.scala
##########
@@ -221,13 +221,15 @@ object DataLoadProcessorStepOnSpark {
modelBroadcast: Broadcast[CarbonLoadModel],
partialSuccessAccum: LongAccumulator,
rowCounter: LongAccumulator,
- keepActualData: Boolean = false): Iterator[CarbonRow] = {
+ keepActualData: Boolean = false,
+ isCompactionFlow: Boolean = false): Iterator[CarbonRow] = {
val model: CarbonLoadModel =
modelBroadcast.value.getCopyWithTaskNo(index.toString)
val conf = DataLoadProcessBuilder.createConfiguration(model)
val badRecordLogger = BadRecordsLoggerProvider.createBadRecordLogger(conf)
Review comment:
instead of adding get/set in badrecord logger we can pass
isCompactionFlow to BadRecordsLoggerProvider.createBadRecordLogger and disable
the BadRecordLogger in that method.
That will be a clean implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
