akashrn5 commented on a change in pull request #4235: URL: https://github.com/apache/carbondata/pull/4235#discussion_r737169929
########## File path: integration/spark/src/main/scala/org/apache/carbondata/streamer/AvroKafkaSource.scala ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.carbondata.streamer + +import scala.collection.JavaConverters._ + +import org.apache.avro.generic.GenericRecord +import org.apache.spark.sql.SparkSession +import org.apache.spark.streaming.StreamingContext +import org.apache.spark.streaming.dstream.DStream +import org.apache.spark.streaming.kafka010.ConsumerStrategies.Subscribe +import org.apache.spark.streaming.kafka010.KafkaUtils +import org.apache.spark.streaming.kafka010.LocationStrategies.PreferConsistent + +import org.apache.carbondata.core.constants.CarbonCommonConstants +import org.apache.carbondata.core.metadata.schema.table.CarbonTable +import org.apache.carbondata.core.util.CarbonProperties + +/** + * This class handles of preparing the Dstream and merging the data onto target carbondata table + * for the kafka Source containing avro data. + * @param carbonTable target carbondata table. + */ +class AvroKafkaSource(carbonTable: CarbonTable) extends Source with Serializable { + + override + def getStream( + ssc: StreamingContext, + sparkSession: SparkSession): CarbonDStream = { + // separate out the non carbon properties and prepare the kafka param + val kafkaParams = CarbonProperties.getInstance() + .getAllPropertiesInstance + .asScala + .filter { prop => !prop._1.startsWith("carbon") } Review comment: there are only some 4 to 5 properties with that and if you send unwanted configs, kafka will take care to ignore it unless used, so it's fine I guess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
