akashrn5 commented on a change in pull request #4224:
URL: https://github.com/apache/carbondata/pull/4224#discussion_r736616416
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java
##########
@@ -67,8 +68,13 @@ public void fillVector(int[] invertedIndex, int[]
invertedIndexReverse, byte[] d
int rowsNum = dataLength / columnValueSize;
CarbonColumnVector vector = vectorInfo.vector;
if (vector.getType().isComplexType()) {
+ if (DataTypes.isStructType(vector.getType())) {
+ int deletedRow = vectorInfo.deletedRows != null ?
vectorInfo.deletedRows.cardinality() : 0;
+ rowsNum = dataLength - deletedRow;
+ } else {
+ rowsNum = dataLength;
Review comment:
please add the comment why for array type we don't need to update with
deleted row. Mention the method name which updates for array type before coming
to this method in the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
