[GitHub] [carbondata] Indhumathi27 commented on a diff in pull request #4280: [CARBONDATA-4339]Fix NullPointerException in load overwrite on partition table

[GitBox]

Indhumathi27 commented on code in PR #4280:
URL: https://github.com/apache/carbondata/pull/4280#discussion_r902185926


##########
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java:
##########
@@ -336,9 +336,10 @@ private String overwritePartitions(CarbonLoadModel 
loadModel, LoadMetadataDetail
           .filter(partitionList::contains).collect(Collectors.toList());
       if (!overlappingPartitions.isEmpty()) {
         List<LoadMetadataDetails> validLoadMetadataDetails =
-            loadModel.getLoadMetadataDetails().stream().filter(
-                loadMetadataDetail -> !loadMetadataDetail.getLoadName()
-                    
.equalsIgnoreCase(newMetaEntry.getLoadName())).collect(Collectors.toList());
+            
loadModel.getLoadMetadataDetails().stream().filter(loadMetadataDetail ->
+                
!loadMetadataDetail.getLoadName().equalsIgnoreCase(newMetaEntry.getLoadName())
+                    && !loadMetadataDetail.getSegmentStatus()
+                    
.equals(SegmentStatus.MARKED_FOR_DELETE)).collect(Collectors.toList());

Review Comment:
   We should filter out segments which has segment state as SUCCESS, otherwise 
the same scenario after compaction will fail



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org