[GitHub] [carbondata] Indhumathi27 commented on a diff in pull request #4287: [CARBONDATA-4346] Remove list files while query and invalid cache

[GitBox]

Indhumathi27 commented on code in PR #4287:
URL: https://github.com/apache/carbondata/pull/4287#discussion_r915474927


##########
core/src/main/java/org/apache/carbondata/core/util/BlockletIndexUtil.java:
##########
@@ -193,7 +154,14 @@ private static BlockMetaInfo createBlockMetaInfo(
         CarbonFile carbonFile = FileFactory.getCarbonFile(carbonDataFile);
         return new BlockMetaInfo(new String[] { "localhost" }, 
carbonFile.getSize());
       default:
-        return 
fileNameToMetaInfoMapping.get(FileFactory.getFormattedPath(carbonDataFile));
+        if (!FileFactory.isFileExist(carbonDataFile)) {
+          return null;
+        }
+        CarbonFile file = 
FileFactory.getCarbonFile(FileFactory.getFormattedPath(carbonDataFile));
+        String[] location = file.getLocations();
+        long len = file.getSize();
+        BlockMetaInfo blockMetaInfo = new BlockMetaInfo(location, len);
+        return blockMetaInfo;

Review Comment:
   can inline line 163 and 164



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org