ShreelekhyaG commented on code in PR #4287:
URL: https://github.com/apache/carbondata/pull/4287#discussion_r918947827
##########
core/src/main/java/org/apache/carbondata/core/util/BlockletIndexUtil.java:
##########
@@ -193,7 +154,11 @@ private static BlockMetaInfo createBlockMetaInfo(
CarbonFile carbonFile = FileFactory.getCarbonFile(carbonDataFile);
return new BlockMetaInfo(new String[] { "localhost" },
carbonFile.getSize());
default:
- return
fileNameToMetaInfoMapping.get(FileFactory.getFormattedPath(carbonDataFile));
+ if (!FileFactory.isFileExist(carbonDataFile)) {
Review Comment:
I have added a generic comment in line:111. As the list files code is
removed, I feel adding an example would create confusion now. I have added an
example and percentage improvement in the pr description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
