[
https://issues.apache.org/jira/browse/CARBONDATA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392221#comment-15392221
]
ASF GitHub Bot commented on CARBONDATA-92:
------------------------------------------
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/50#discussion_r72096754
--- Diff:
core/src/main/java/org/carbondata/core/carbon/datastore/chunk/impl/FixedLengthDimensionDataChunk.java
---
@@ -69,9 +69,31 @@ public FixedLengthDimensionDataChunk(byte[] dataChunk,
DimensionChunkAttributes
}
/**
+ * Converts to column dictionary integer value
+ * @param rowId
+ * @param columnIndex
+ * @param row
+ * @param restructuringInfo @return
--- End diff --
What is the return value
> Remove the unnecessary intermediate conversion of key while scanning.
> ---------------------------------------------------------------------
>
> Key: CARBONDATA-92
> URL: https://issues.apache.org/jira/browse/CARBONDATA-92
> Project: CarbonData
> Issue Type: Improvement
> Reporter: Ravindra Pesala
>
> Remove the unnecessary intermediate conversion of key while scanning.
> Basically it removes one step in result conversion.
> It avoids System.arraycopy while converting to result.
> It avoids the result preparation step.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
