Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/56#discussion_r74122285
--- Diff:
core/src/main/java/org/carbondata/core/carbon/datastore/block/TableBlockInfo.java
---
@@ -185,6 +207,16 @@ public long getBlockLength() {
> ((TableBlockInfo) other).blockOffset + ((TableBlockInfo)
other).blockLength) {
return 1;
}
+ //compare the startBlockLetNumber
+ int diffStartBlockLetNumber =
+ blockletInfos.getStartBlockletNumber() - ((TableBlockInfo)
other).blockletInfos
--- End diff --
@PraveenAdlakha your point is valid. We can refactor this code. Can you
work on it and provide the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
