[
https://issues.apache.org/jira/browse/CARBONDATA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418499#comment-15418499
]
ASF GitHub Bot commented on CARBONDATA-154:
-------------------------------------------
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/70#discussion_r74554497
--- Diff: core/src/main/java/org/carbondata/scan/filter/FilterUtil.java ---
@@ -669,27 +669,14 @@ public static DimColumnFilterInfo
getFilterListForAllMembersRS(Expression expres
* @param segmentProperties
* @return long[] start key
*/
- public static long[] getStartKey(DimColumnResolvedFilterInfo
dimColResolvedFilterInfo,
- SegmentProperties segmentProperties, long[] startKey) {
- Map<CarbonDimension, List<DimColumnFilterInfo>> dimensionFilter =
- dimColResolvedFilterInfo.getDimensionResolvedFilterInstance();
- for (Map.Entry<CarbonDimension, List<DimColumnFilterInfo>> entry :
dimensionFilter.entrySet()) {
- List<DimColumnFilterInfo> values = entry.getValue();
- if (null == values ||
!entry.getKey().hasEncoding(Encoding.DICTIONARY)) {
- continue;
- }
- boolean isExcludePresent = false;
- for (DimColumnFilterInfo info : values) {
- if (!info.isIncludeFilter()) {
- isExcludePresent = true;
- }
- }
- if (isExcludePresent) {
- continue;
- }
- getStartKeyBasedOnFilterResoverInfo(dimensionFilter, startKey);
+ public static void getStartKey(Map<CarbonDimension,
List<DimColumnFilterInfo>> dimensionFilter,
+ AbsoluteTableIdentifier tableIdentifier, long[] startKey,
SegmentProperties segmentProperties,
--- End diff --
no use of `tableIdentifier` and `segmentProperties`, please remove from
static method.
> Block prune can not get the right blocks and query result is wrong
> ------------------------------------------------------------------
>
> Key: CARBONDATA-154
> URL: https://issues.apache.org/jira/browse/CARBONDATA-154
> Project: CarbonData
> Issue Type: Bug
> Reporter: zhangshunyu
> Priority: Critical
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
