[ 
https://issues.apache.org/jira/browse/CARBONDATA-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418765#comment-15418765
 ] 

Praveen Adlakha commented on CARBONDATA-129:
--------------------------------------------

Hi ,

I am not sure whether you are talking about null check for CarbonProperties or 
the value we are adding.

Had a look at the code CarbonPropeties is a singelton class so cannot be null 
for values that we are adding already null check is there however there was no 
empty check have added it in :

https://github.com/apache/incubator-carbondata/pull/73

> Do null check before adding value to CarbonProperties
> -----------------------------------------------------
>
>                 Key: CARBONDATA-129
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-129
>             Project: CarbonData
>          Issue Type: Bug
>          Components: spark
>            Reporter: Ashok Kumar
>            Priority: Critical
>
> CarbonGlobalDictionaryRDD 
> We are adding value to CarbonProperties without check if its null.
> If added value is null then error will come. Its better to do null check 
> before adding value to CarbonProperties.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to