GitHub user foryou2030 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/82

    [CARBONDATA-165] Support loading fact file with header for all dictionary

    # Why raise this pr?
    When fact csv already have header and  giving FILEHEADER along with  
ALL_DICTIONARY_PATH option ,  header will be considered as data row , which is 
not correct.
    FILEHEADER option must be given only when CSV do not have header .  We can 
read the header from fact file when FILEHEADER  is not  given with 
ALL_DICTIONARY_PATH 
    
    # How to solve?
    Add adapter for loading data with header. While loading fact CSV file with 
header, get file header from fact file instead of option("FILEHEADER") (the 
interface "getHeaderFormFactFile" did this)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/foryou2030/incubator-carbondata 
all_dict_header

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/82.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #82
    
----
commit 79d4b0ae87a58cd3437fc6f19bba9865afcac417
Author: foryou2030 <[email protected]>
Date:   2016-08-22T10:00:00Z

    adapt data with header for all dictionary

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to