Github user Vimal-Das commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/95#discussion_r76512969
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastorage/store/compression/type/UnCompressNonDecimalMaxMinByte.java
---
@@ -93,7 +95,9 @@
if (value[i] == 0) {
vals[i] = maxValue;
} else {
- vals[i] = (maxValue - value[i]) / Math.pow(10, decimalVal);
+ BigDecimal diff = new BigDecimal(Double.toString(value[i] /
Math.pow(10, decimalVal)));
--- End diff --
use BigDecimal.valueOf(double) instead of converting to string for
performance and dataloss concerns.refer
http://www.javaworld.com/article/2073176/caution--double-to-bigdecimal-in-java.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
