Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/92#discussion_r76606495
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/lcm/status/SegmentStatusManager.java
 ---
    @@ -410,18 +410,26 @@ public void writeLoadDetailsIntoFile(String 
dataLoadLocation,
           for (LoadMetadataDetails loadMetadata : 
listOfLoadFolderDetailsArray) {
     
             if (loadId.equalsIgnoreCase(loadMetadata.getLoadName())) {
    +          // if the segment is compacted then no need to delete that.
    +          if (CarbonCommonConstants.SEGMENT_COMPACTED
    +              .equalsIgnoreCase(loadMetadata.getLoadStatus())) {
    +            LOG.error("Cannot delete the Segment which is compacted. 
Segment is " + loadId);
    +            loadFound = true;
    +            invalidLoadIds.add(loadId);
    --- End diff --
    
    Above two lines are not required as we are deleting  all or none


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to