Github user Zhangshunyu commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/110#discussion_r76929947
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/ValueCompressionUtil.java ---
@@ -78,26 +78,26 @@ private ValueCompressionUtil() {
private static DataType getDataType(double value, int decimal, byte
dataTypeSelected) {
DataType dataType = DataType.DATA_DOUBLE;
if (decimal == 0) {
- if (value < Byte.MAX_VALUE) {
+ if (value < Byte.MAX_VALUE && value > Byte.MIN_VALUE) {
--- End diff --
Before i modified to use new "absMaxValue", it is needed, but now i can
detele this code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
