Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/137#discussion_r77950155
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/impl/btree/BTreeDataRefNodeFinder.java
---
@@ -240,9 +240,16 @@ private int compareIndexes(IndexKey first, IndexKey
second) {
firstNoDictionaryKeyBuffer.getShort(nonDictionaryKeyOffset +
SHORT_SIZE_IN_BYTES);
secondNodeDictionaryLength =
secondNoDictionaryKeyBuffer.getShort(nonDictionaryKeyOffset
+ SHORT_SIZE_IN_BYTES);
- compareResult = ByteUtil.UnsafeComparer.INSTANCE
- .compareTo(first.getNoDictionaryKeys(), actualOffset,
firstNoDcitionaryLength,
- second.getNoDictionaryKeys(), actualOffset,
secondNodeDictionaryLength);
+ int minLength = Math.min(firstNoDcitionaryLength,
secondNodeDictionaryLength);
--- End diff --
@kumarvishal09 please comment on this. I am not getting how actualOffset is
same for both keybuffers.
Also as I know length can be calculated by nextOffset-currentOffset. Please
give the structure of data stored and how this function works
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
