Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/156#discussion_r79111804
--- Diff:
processing/src/main/java/org/apache/carbondata/lcm/status/SegmentStatusManager.java
---
@@ -246,15 +247,22 @@ private Integer compareDateValues(Long loadValue,
Long userValue) {
* updates deletion status
* @param loadIds
* @param tableFolderPath
+ * @param dbName
+ * @param tableName
* @return
*/
- public List<String> updateDeletionStatus(List<String> loadIds, String
tableFolderPath) {
- ICarbonLock carbonLock = CarbonLockFactory
+ public List<String> updateDeletionStatus(List<String> loadIds, String
tableFolderPath,
+ String dbName, String tableName) throws Exception {
--- End diff --
I think no need to to change the method signature here...database name and
table name can be taken from carbontable identifier and carbonTableIdentifier
object is available in the mehod
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
