Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/161#discussion_r79289289
  
    --- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
 ---
    @@ -102,6 +102,11 @@ class CarbonMergerRDD[K, V](
             var dataloadStatus = CarbonCommonConstants.STORE_LOADSTATUS_FAILURE
             val carbonSparkPartition = 
theSplit.asInstanceOf[CarbonSparkPartition]
     
    +        // get destination segment properties as sent from driver which is 
of last segment.
    +
    +        val segmentProperties = new 
SegmentProperties(carbonMergerMapping.columnSchemaList.asJava,
    --- End diff --
    
    rename it to maxSegmentcolumnSchemaList and maxSegmentColCardinality.
    Write comment where it is declared


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to