Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/176#discussion_r79554930
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonTimeStatisticsFactory.java
---
@@ -52,12 +56,27 @@ public static LoadStatistics
getLoadStatisticsInstance() {
return LoadStatisticsInstance;
}
- private static DriverQueryStatisticsRecorder
genQueryStatisticsRecorderInstance() {
- return DriverQueryStatisticsRecorder.getInstance();
+ private static QueryStatisticsRecorder
genQueryStatisticsRecorderInstance() {
+ if (queryStatisticsRecorderInstanceType.equalsIgnoreCase("true")) {
+ return DriverQueryStatisticsRecorderImpl.getInstance();
+ } else {
+ return DriverQueryStatisticsRecorderDummy.getInstance();
+ }
}
- public static DriverQueryStatisticsRecorder
getQueryStatisticsRecorderInstance() {
+ public static QueryStatisticsRecorder
getQueryStatisticsRecorderInstance() {
return QueryStatisticsRecorderInstance;
}
+ public static QueryStatisticsRecorder getQueryStatisticsRecorder(String
queryId) {
--- End diff --
I think rename it to createRecorder is better than 'get'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
