Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/189#discussion_r81279790
--- Diff: format/src/main/thrift/schema.thrift ---
@@ -124,6 +124,7 @@ struct TableSchema{
1: required string table_id; // ID used to
2: required list<ColumnSchema> table_columns; // Columns in the table
3: required SchemaEvolution schema_evolution; // History of schema
evolution of this table
+ 4: optional i32 block_size
--- End diff --
@Zhangshunyu ...I agree with @jackylk ...just like we are storing the table
path in metastore, same way block size can also be stored as it is metadata for
the table. schema file we write should only describe the structure the table
and not the metadata for table
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
