GitHub user Zhangshunyu opened a pull request:
https://github.com/apache/incubator-carbondata/pull/225
Abstract Snappy interface and seperate it from Compressor interface
## Why raise this pr?
Currently, we only have snappy compressor who extends form Compressor
interface, for future expansion, we need to abstract Snappy interface and
seperate it from Compressor interface, it means `Compressor interface is the
parent of all compressors, and SnappyCompressor and the other compressor's
interface should extends Compressor interface, as to different data type for
different compressor, it would extend its own interface.`
## How to test?
Pass all the test cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Zhangshunyu/incubator-carbondata
compress_interface
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/225.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #225
----
commit 98536737d786c40192d197a3af3e52254949d4fd
Author: Zhangshunyu <[email protected]>
Date: 2016-10-10T09:17:31Z
Abstract Snappy interface and seperate it from Compressor interface
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---