Github user jackylk commented on a diff in the pull request:
    --- Diff: 
    @@ -0,0 +1,40 @@
    +package org.apache.carbondata.processing.newflow;
    +import java.util.Iterator;
    + * This base interface for data loading. It can do transformation jobs as 
per the implementation.
    + *
    + */
    +public interface DataLoadProcessorStep {
    --- End diff --
    I think each implementation of this interface have similar logic in the 
execute function, can we create a abstract class to implement the common logic? 
    The common logic like:
    Iterator<Object[]> execute() throws CarbonDataLoadingException {
        Iterator childIter = child.execute();
        return new Iterator<Object[]> {
              public boolean hasNext() { 
                    return childIter.hasNext();
              public Object[] next() {
                    // processInput is the abstract func in this class
                    return processInput(;

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to