Github user jackylk commented on a diff in the pull request:
    --- Diff: 
    @@ -0,0 +1,85 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.carbondata.processing.newflow.dictionary;
    +import java.util.Map;
    +import org.apache.carbondata.core.devapi.DictionaryGenerator;
    +import org.apache.carbondata.core.devapi.GeneratingBiDictionary;
    +public class InMemBiDictionary<K, V> extends GeneratingBiDictionary<K, V> {
    --- End diff --
    This `InMemBiDictionary` is for one column, when it comes to cache, I think 
the cached object is 'BiDictionary`. Since the cache provides KV API, so we 
need a TableDictionary to make use of the cache. I am thinking to add another 
class for table dictionary, like 
    CachedTableDictionary tableDict = new CachedTableDictionary(tableName)
    key = tableDict.getOrGenerateKey(columnName, value)
    Inside `CachedTableDictionary`, it will maintain a cache of 
`HashMap<columnName, BiDictionary>`
    I am thinking to use 
[Cache]( from Guava also

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to