Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/241#discussion_r83584798
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java
 ---
    @@ -1237,6 +1237,9 @@ else if(isComplexTypeColumn[j]) {
     
       private void addEntryToBadRecords(Object[] r, int j, String columnName,
           String dataType) {
    +    if (DataType.LONG.toString().equals(dataType)) {
    --- End diff --
    
    This check is not required.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to