Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/248#discussion_r84401103
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -175,8 +177,12 @@ object CarbonDataRDDFactory extends Logging {
}
def configSplitMaxSize(context: SparkContext, filePaths: String,
- hadoopConfiguration: Configuration): Unit = {
- val defaultParallelism = if (context.defaultParallelism < 1) 1 else
context.defaultParallelism
+ hadoopConfiguration: Configuration): Unit = {
--- End diff --
in this case, write in one line is ok, no need to modify. better approach
is to use min function instead of if else
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
