Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/247#discussion_r84492901
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java
---
@@ -334,24 +151,24 @@ public void startSorting() throws
CarbonSortKeyAndGroupByException {
toSort = new Object[entryCount][];
System.arraycopy(recordHolderList, 0, toSort, 0, entryCount);
- if (noDictionaryCount > 0) {
- Arrays.sort(toSort, new RowComparator(noDictionaryDimnesionColumn,
noDictionaryCount));
+ if (parameters.getNoDictionaryCount() > 0) {
+ Arrays.sort(toSort, new
RowComparator(parameters.getNoDictionaryDimnesionColumn(),
+ parameters.getNoDictionaryCount()));
} else {
- Arrays.sort(toSort, new
RowComparatorForNormalDims(this.dimColCount));
+ Arrays.sort(toSort, new
RowComparatorForNormalDims(parameters.getDimColCount()));
}
recordHolderList = toSort;
// create new file
- File file =
- new File(this.tempFileLocation + File.separator + this.tableName
+ System.nanoTime() +
- CarbonCommonConstants.SORT_TEMP_FILE_EXT);
+ File file = new File(
+ parameters.getTempFileLocation() + File.separator +
parameters.getTableName() + System
--- End diff --
move System to next line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
