Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/249#discussion_r84567557
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -19,866 +19,859 @@
package org.apache.carbondata.core.constants;
-public final class CarbonCommonConstants {
+public interface CarbonCommonConstants {
--- End diff --
@ravipesala @gvramana @Vimal-Das
What is your opinion. Refer to
[this](http://stackoverflow.com/questions/320588/interfaces-with-static-fields-in-java-for-sharing-constants)
saying constant in interface is not a good practice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
