I agree with Ravindra, this is not the best approach. But since this issue block integration with Apache CI, I think it makes sense to solve it quickly and do the best approach later. Without CI automation, it is really a pain to manually trigger the CI for every PR.
So, +1 Regards, Jacky > 在 2016年10月24日，下午7:17，Jean-Baptiste Onofré <[email protected]> 写道： > > +1 > > It makes sense to me. > > Regards > JB > > > > On Oct 24, 2016, 13:03, at 13:03, Vimal Das Kammath > <[email protected]> wrote: >> Yes, I agree with Ravindra and Vishal. >> Instead of the source code, we can have the jar published to >> repository, >> We can have a maven profile that depends on carbon-format as jar from >> repository (this can be the default, for new developers to build >> successfully) >> However, We also should have a profile that compiles the thrift files >> and >> publishes the jar which can be used by CI and developer who wants to >> modify >> the .thrift files. >> >> Regards >> Vimal >> >> On Mon, Oct 24, 2016 at 3:13 PM, Kumar Vishal >> <[email protected]> >> wrote: >> >>> In case of any updation in thrift we need to update the java files. I >> think >>> keeping the java file is not a good idea. >>> >>> -Regards >>> >>> Kumar Vishal >>> >>> On Oct 24, 2016 13:13, "caiqiang" <[email protected]> wrote: >>> >>>> Hi >>>> >>>> Currently, There are two typical Thrift issues: >>>> >>>> 1.Users want to directly build Apache CarbonData, don’t need to >> install >>>> Thrift in advance. For example: >>>> >>>> Julian Hyde-3’s feedback in IPMC mailing list: I was not able to >> build >>>> (not your fault - I did not have thrift >>>> installed and didn't have the time & patience to install it). >>>> >>>> 2.Need to fix Apache Jenkins CI issues, as below: >>>> >>>> [ERROR] Failed to execute goal org.apache.thrift.tools:maven- >>> thrift-plugin:0.1.11:compile >>>> (generate-thrift-java) on project carbondata-format: thrift did not >> exit >>>> cleanly. Review output for more information. -> [Help 1] >>>> >>>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to >>> execute >>>> goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile >>>> (generate-thrift-java) on project carbondata-format: thrift did not >> exit >>>> cleanly. Review output for more information. >>>> >>>> For solving the above mentioned Thrift issues, i would like to >> propose >>> one >>>> solution: Directly use java code ( thrift compiler compile >> carbondata >>>> format files to java code) to build, then users don't need to do >> any >>>> thrift installation. >>>> >>>> please vote and comment : >>>> >>>> To continue use the current manual install method to build >>>> >>>> or >>>> >>>> To directly use java code which be generated by thrift compiler to >> build >>>
