+1 for Proposal 1 Best Regards, Aniket
On Wed, Nov 16, 2016 at 10:34 AM, Liang Chen <[email protected]> wrote: > Hi all > > Please vote the below proposals or advise other better proposal on building > thrift files. > > > ------------------------------------------------------------ > --------------------------- > > CarbonData is file format and introduce Apache thrift for supporting > multiple languages and any language can read the file format written by > thrift. > > > > Following are 2 proposals to build thrift file > > > > *Proposal 1:* provide dependency in maven pom file. > > For people(IPMC,PPMC, and others)who want to verify release need to install > thrift for building with this command "mvn clean -Pbuild-with-format > install". > > For general users: no need to install thrift and build with command "mvn > clean install", because the dependency provided in maven pom file(already > uploaded the compiled format jar to snapshot repository for dev, and to > release repository once released) > > > > pros: use jar dependency, easy to manage. > > cons: only verify release need to install thrift. > > > > *Proposal 2: *generate thrift java code and add to system for building > without thrift installation > > > > For people(IPMC,PPMC,and others) who want to verify release,no need to > install thrift and build with command "mvn clean install". > > > pros: no thrift installation for verify release > > cons: introduce around 10k java code to system, for every language(like > C++),need introduce more code. > > > Regards > Liang >
