> On 4 Jun 2014, at 7:24 am, Dave Brosius <dbros...@mebigfatguy.com> wrote:
> 
> The solution to several of these issues is,
> 
> Refactor 1 singleton use case, and post a patch.

+1 do it slowly

-1 for adding a dependency on a dependency injection framework. It's not 
strictly needed if your goal is for removing singletons and improving 
testability.

> 
> 1) less classes are involved
> 2) the review is more likely to be understood by one person
> 3) less chance for regression
> 4) marginally more modular code
> 
> When that goes well, pick another one.

Reply via email to